Skip to content

🎨 Palette: [UX improvement] - Fix custom view roles and sibling spacing#107

Open
manupawickramasinghe wants to merge 1 commit into
mainfrom
ux/improve-accessibility-roles-spacing-17887191141488524281
Open

🎨 Palette: [UX improvement] - Fix custom view roles and sibling spacing#107
manupawickramasinghe wants to merge 1 commit into
mainfrom
ux/improve-accessibility-roles-spacing-17887191141488524281

Conversation

@manupawickramasinghe
Copy link
Copy Markdown
Member

💡 What:

  1. Added semantic button roles (info.className = Button::class.java.name) to custom clickable TextView views (textView6 for IP copy, textView2 for Repo link).
  2. Added android:layout_marginEnd="16dp" to horizontally stacked sibling controls (buttonKill, qual_feedback) in fragment_camera.xml.

🎯 Why:

  1. Screen readers were announcing the text of the custom clickable views, but without a semantic role, users might not realize they are interactive buttons.
  2. Sibling elements in horizontal layouts lacked consistent spacing, creating cluttered visual padding and increasing the risk of mis-taps on touch screens.

📸 Before/After:

  • Before: Custom clickable views lacked semantic context for screen readers; the Stop button and Bitrate text were flush against the edge or adjacent elements.
  • After: Screen readers announce "Button" for custom clickable views; horizontal elements have consistent 16dp spacing.

♿ Accessibility:

  • Improved structural context for visually impaired users by explicitly declaring interactive custom views as "Buttons" to assistive technologies.
  • Improved motor accessibility and touch targets by strictly enforcing a minimum 16dp margin between sibling elements.

PR created automatically by Jules for task 17887191141488524281 started by @manupawickramasinghe

* Add `info.className = Button::class.java.name` to custom link/copy TextViews so TalkBack announces them correctly
* Add `android:layout_marginEnd="16dp"` to horizontal sibling controls in fragment_camera.xml to ensure uniform touch target spacing

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings May 10, 2026 20:39
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants