⚡ Bolt: Refactor firmware python scripts to bound memory usage to O(1)#71
⚡ Bolt: Refactor firmware python scripts to bound memory usage to O(1)#71ManupaKDU wants to merge 4 commits into
Conversation
Signed-off-by: Jules <jules@example.com> Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
This commit optimizes scripts/belkin-header.py and scripts/tplink-mkimage-2022.py to bound memory usage to O(1) via streaming logic utilizing 64KB blocks. Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
This commit optimizes scripts/belkin-header.py and scripts/tplink-mkimage-2022.py to bound memory usage to O(1) via streaming logic utilizing 64KB blocks. Signed-off-by: Jules [bot] <jules@example.com> Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
1 participant
💡 What:
Updated
scripts/belkin-header.pyandscripts/tplink-mkimage-2022.pyto stream large file reads and generation utilizing 64KB block chunks, as well as native standard library functions likeshutil.copyfileobj.🎯 Why:
These scripts historically parsed large firmware blobs by loading the entirety of them into memory immediately via
.read(). This causes enormous O(N) memory bloat, risking excessive GC calls or Out-Of-Memory errors during the build steps in constrained environments.📊 Impact:
Memory footprint for reading or outputting files is successfully bounded to O(1) in these script operations, substantially reducing the amount of immediate RAM consumed.
🔬 Measurement:
Running
python3 scripts/belkin-header.pyorpython3 scripts/tplink-mkimage-2022.pydirectly alongside dummy binary files. Tested utilizingos.getsizeand inspecting the binaries. Memory constraints can also be observed scaling appropriately using tooling such asmprof.PR created automatically by Jules for task 3661325149365626501 started by @manupawickramasinghe