Conversation
Implements issue Zenith-options#115 — Adversarial Counterparty Mock Suite. New crate: test_adversaries/ (rlib, dev-dependency only, never deployed) - tokens: LyingBalanceToken, FeeOnTransferToken, RevertOnTransferToken, ReentrantToken, ZeroBalanceToken, OverflowToken - oracle: AlwaysNoneOracle, ExtremeHighOracle, ExtremeLowOracle, RevertingOracle, StaleOracle, NegativePriceOracle - vault: NoOpVault, WrongBalanceVault, RevertOnWithdrawVault, DrainVault - multisig: AlwaysApproveMultisig, NeverApproveMultisig, SingleSignerMultisig, ExpiredApprovalMultisig Negative test files (35 tests, 33 ignored pending implementation): - options_market/src/test_adversaries.rs - price_oracle/src/test_adversaries.rs - vault/src/test_adversaries.rs 4 live tests run immediately against already-implemented code: - oracle_adapter: both-None sources return NoValidPrice (not 0) - vault token_validation: ZeroTransfer guard, FeeOnTransfer DeltaMismatch, RevertOnTransfer propagation Ignored tests carry #[ignore = "issue Zenith-options#115: ..."] and are un-ignored by the fix PRs that close each individual vulnerability. Also: - Add test_adversaries dev-dependency to options_market, price_oracle, vault Cargo.toml - Wire #[cfg(test)] mod test_adversaries into each lib.rs - Add adversary catalog to README.md and test_adversaries/CATALOG.md
|
@bumblebee-2020 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…al-mock-suite # Conflicts: # options_market/Cargo.toml # options_market/src/lib.rs # price_oracle/Cargo.toml # price_oracle/src/lib.rs # vault/Cargo.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #115
Closes #112
Closes #113
Closes #114