Skip to content

P3/P4: run_report.v1 for Hyperlex eval scripts (report-only) + validity separate from score - #21

Merged
scrimshawlife-ctrl merged 6 commits into
mainfrom
feat/run-report-v1
Oct 17, 2026
Merged

scrimshawlife-ctrl merged 6 commits into
mainfrom
feat/run-report-v1

Conversation

@scrimshawlife-ctrl

Copy link
Copy Markdown
Contributor

Stacked on #20 (contains its commits; review #20 first).

  • New scripts/shadow/hyperlexical/run_report.py: a context manager that does nothing unless HLX_RUN_REPORT is set. It writes run_report.v1 (status, inputs without row text, counts, scores, validity, warnings, errors) and never changes eval numbers, stdout, or exit codes. A failed write does not raise.
  • Wired into eval_unbind.main and eval_classify.main. eval_classify is ported verbatim from archived ad4075b plus its deps.
  • P4: validity counts predictions that parse to a known family separately from the task score (macro-F1 etc.).
  • Tests: 7 run_report + 2 wiring tests (stdout identical with and without the env var; an invalid label is counted). Full local: 54 passed. The CI workflow now runs tests/shadow + tests/heldout.
  • rc3/rc4 runs and prereg are untouched; they run from the archived clone.

Code by deepseek-v4.1-flash via the Jev router; wiring is a small reviewed hand patch. Do not merge without Danny's yes.

@scrimshawlife-ctrl
scrimshawlife-ctrl requested a review from a team as a code owner October 12, 2026 10:54
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T10:58:02.874225Z 098c7f7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

CC @Zero-State-LLC/partner-agents. Flagged for shared triage.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 098c7f7076

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/shadow/hyperlexical/eval_unbind.py
Comment thread scripts/shadow/hyperlexical/eval_classify.py Outdated
Comment thread scripts/shadow/hyperlexical/PORTED.md
cursoragent and others added 4 commits October 17, 2026 18:22
Port recoverable_structure from archived ad4075b so the training export imports in a clean checkout. Resolve the bundled hyperlexical module before an exposure snapshot is published. Refuse holdout identity fields that are not lists of strings.

Co-authored-by: Daniel Meyer <scrimshawlife-ctrl@users.noreply.github.com>
Keep the run-report workflow, which already runs tests/shadow and tests/heldout, so the holdout fixes and the report tests stay in one job.

Co-authored-by: Daniel Meyer <scrimshawlife-ctrl@users.noreply.github.com>
… intent

Validity now uses the labels run_eval_classify actually scored, so padding and extra prediction rows do not change the count. intent/2026-10-12-run-report-v1.md records the accepted harness-learning port.

Co-authored-by: Daniel Meyer <scrimshawlife-ctrl@users.noreply.github.com>
Keep main's holdout-guard port and add this branch's run_report tests, the intent pointer in PORTED.md, and the eval_unbind report wiring.

Co-authored-by: Daniel Meyer <scrimshawlife-ctrl@users.noreply.github.com>
@scrimshawlife-ctrl
scrimshawlife-ctrl merged commit d1e4e12 into main Oct 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants