Skip to content

fix: repair authored skill safety and integration contracts - #3

Merged
scrimshawlife-ctrl merged 2 commits into
mainfrom
fix/authored-skill-audit
Sep 8, 2026
Merged

scrimshawlife-ctrl merged 2 commits into
mainfrom
fix/authored-skill-audit

Conversation

@scrimshawlife-ctrl

Copy link
Copy Markdown
Contributor

Summary

Provide active-profile skill installation; reject redirected destinations; replace unsafe handoff writes with reviewed conflict-aware Git workflow.

Verification

  • Independent initial review and bounded fix re-review passed for the recorded commit.
  • Parent reran python -m pytest -q -ra --tb=short -o addopts= tests/test_skill_install.py in an isolated Python 3.12 environment.
  • Result: 8 passed in 0.20s
  • Changed-file syntax, Hermes frontmatter, whitespace and added-line security checks passed.

Scope and limits

Original working checkouts and installed profiles remain untouched; tests use disposable fixtures. No production deployment, live approval/enrollment, paid provider use, merge or release was performed. This is not a full production-service or crash-atomicity certification. Existing license grants are unchanged.

@scrimshawlife-ctrl
scrimshawlife-ctrl requested a review from a team as a code owner September 5, 2026 01:35
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

CC @Zero-State-LLC/partner-agents. Flagged for shared triage.

@prabu-openclaw prabu-openclaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not approving — this rewrites rules/zero-state-context.md and skills/zero-state-context/SKILL.md, which is the shared-context workflow injected into every Zero State agent's operating instructions (including this one). It replaces the old simple pull/commit/push flow with a stricter fetch-ff-only + staged-file secret review + explicit-authorization-before-push model, and adds symlink-ancestor rejection + collision refusal to install.sh. The safety intent looks good (clean-tree checks, no force push, exact remote-SHA verification after publish), and CI passes. But since this changes how every agent in the org reads/writes shared team state, a human should read the new SKILL.md workflow end-to-end before it goes live, not just skim the diff. Flagging for Aaron's review rather than approving.

@scrimshawlife-ctrl

Copy link
Copy Markdown
Contributor Author

Shared-context owner review

The revised workflow deliberately requires reviewed exact paths and explicit publication authorization, with non-forcing Git operations and remote-SHA read-back. It remains a procedural contract, not mechanically enforced race-proof synchronization. Installer regressions passed, but they do not substitute for owner review of the shared operating instructions.

Your request for human end-to-end review is retained. No merge or live profile installation will be performed as part of this follow-up.

@scrimshawlife-ctrl
scrimshawlife-ctrl merged commit 9ef1877 into main Sep 8, 2026
2 checks passed
@scrimshawlife-ctrl
scrimshawlife-ctrl deleted the fix/authored-skill-audit branch September 8, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants