Repository navigation
fix: repair authored skill safety and integration contracts - #3
Conversation
|
CC @Zero-State-LLC/partner-agents. Flagged for shared triage. |
prabu-openclaw
left a comment
There was a problem hiding this comment.
Not approving — this rewrites rules/zero-state-context.md and skills/zero-state-context/SKILL.md, which is the shared-context workflow injected into every Zero State agent's operating instructions (including this one). It replaces the old simple pull/commit/push flow with a stricter fetch-ff-only + staged-file secret review + explicit-authorization-before-push model, and adds symlink-ancestor rejection + collision refusal to install.sh. The safety intent looks good (clean-tree checks, no force push, exact remote-SHA verification after publish), and CI passes. But since this changes how every agent in the org reads/writes shared team state, a human should read the new SKILL.md workflow end-to-end before it goes live, not just skim the diff. Flagging for Aaron's review rather than approving.
Shared-context owner reviewThe revised workflow deliberately requires reviewed exact paths and explicit publication authorization, with non-forcing Git operations and remote-SHA read-back. It remains a procedural contract, not mechanically enforced race-proof synchronization. Installer regressions passed, but they do not substitute for owner review of the shared operating instructions. Your request for human end-to-end review is retained. No merge or live profile installation will be performed as part of this follow-up. |
Summary
Provide active-profile skill installation; reject redirected destinations; replace unsafe handoff writes with reviewed conflict-aware Git workflow.
Verification
python -m pytest -q -ra --tb=short -o addopts= tests/test_skill_install.pyin an isolated Python 3.12 environment.Scope and limits
Original working checkouts and installed profiles remain untouched; tests use disposable fixtures. No production deployment, live approval/enrollment, paid provider use, merge or release was performed. This is not a full production-service or crash-atomicity certification. Existing license grants are unchanged.