Repository navigation
Write 12 edge case regression tests and fix the bugs. - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All 12 regression tests failed or showed the problem on the old code, and the full suite now passes (844 of 844, 4 m 42 s).
What each fix does
high-waterfile at the store root. A new boundary always comes after that day.RollOverPartitionsreturned 0salt-used:keys) and is destroyed one day after that use. Salts for today and yesterday keep the old date rule (VisitorHasher.cs).Text.NameandText.Valuereplace unpaired surrogates with U+FFFD before hashing and storing (Text.cs).Encodedidn't throwRawEventCodec.Encoderejects them; the strict decoder throwsFormatException.SessionStatewith no dimensionsIndexOutOfRangeExceptionwhen written, and the session was lostjournal-a.bin/journal-b.bin).Existing tests changes
PublicStorageCodecTests: only the escaping change above. Every assertion is the same.EngineTests.cs:663: Updated a comment that described the old salt lifetime. The assertions are unchanged.