[Chore] Start CodeRabbit review once Ubuntu tests pass - #1581
[Chore] Start CodeRabbit review once Ubuntu tests pass#1581zoomote[bot] wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review statusThis PR was opened by an automated account. A human maintainer must verify the change intent, provenance, and validation before merging. Current step: Mark the PR ready. Required CI must pass before CodeRabbit starts. Review-state labels are managed by this workflow; do not edit them manually. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Related GitHub Issue
Requested by a maintainer in Discord (no tracking issue): CodeRabbit review currently waits for the entire required CI matrix, including the slow Windows test jobs, before it starts.
Description
The review-state reconciliation in
label-pr-review-state.ymlonly activated CodeRabbit after every required check passed. This change keeps the full-CI gate (state labels,Zoo Code / PR review gatestatus, review-guide messaging) exactly as it is, but computes a separate activation condition in the CI-pending branch: CodeRabbit is activated once all required checks except the Windows test jobs (platform-unit-test (windows-…)) have concluded successfully, provided nothing — including Windows — has failed.Details reviewers may care about:
/\(windows-[^)]*\)/match on the required check context, matching theplatform-unit-test (windows-latest)matrix job incode-qa.yml.coderabbit-review-label:<sha>marker, so when the remaining Windows jobs later go green the already-bound activation is kept instead of being recycled (which would re-trigger CodeRabbit on the same commit). An activation label left over from an older head is still recycled.Test Procedure
pnpm --dir src exec vitest run services/__tests__/pr-review-state-workflow.test.ts— 111 tests pass, including new coverage for: activation when Ubuntu passed and Windows is still running, no activation while Ubuntu is pending, no activation when Ubuntu failed, no activation when Windows failed, no recycling of an early activation bound to the current head, recycling from an older head, and unchanged all-tests-passed behavior.pnpm --dir src run check-types— clean.pnpm testfrom the repo root — passes (10/10 turbo tasks).Pre-Submission Checklist
*.visual.tsxsnapshot inwebview-ui/. Seewebview-ui/AGENTS.md→ "When a UI change needs a snapshot".Documentation Updates
Additional Notes
The state machine phases,
maintainerApprovedAfterAutomatedReviewordering, and gate descriptions are intentionally untouched; only the timing of thecoderabbit-review-activelabel changes.Get in Touch
Roomote (bot) — reach the requesting maintainer via the linked Discord thread above.