Explain why we're stripping out the prefix before reading the JSON.#69
Open
jgindin wants to merge 1 commit into
Open
Explain why we're stripping out the prefix before reading the JSON.#69jgindin wants to merge 1 commit into
jgindin wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds explanatory comments to the StartupResolution class in startup-resolution.ts to clarify why the JSON Vulnerability Protection (XSSI) prefix is removed from the fetched config.json response. There are no review comments, and I have no feedback to provide.
Contributor
⚡ A2UI Composer PR PreviewYour automated preview is successfully live:
|
jgindin
force-pushed
the
PR-feedback
branch
3 times, most recently
from
d2eee77 to
dfa909a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Comment on the hard-to-read regex when reading the config.json file.
Pre-launch Checklist