bundle ng-basic-catalog as default out-of-the-box renderer#71
Conversation
⚡ A2UI Composer PR PreviewYour automated preview is successfully live:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for relative renderer URLs (starting with '/') across the application, updating the configuration, settings validation, query parser, and preview bridge fetch calls accordingly. It also integrates dynamic initial draft pre-population based on the active catalog. The reviewer feedback highlights three main areas for improvement: addressing potential state desynchronization when switching active catalogs, using JSON.stringify instead of template string interpolation to construct JSON safely, and replacing corepack yarn with standard yarn in the package scripts for better portability and consistency.
jgindin
force-pushed
the
fast-start
branch
4 times, most recently
from
2d74a02 to
7826a66
Compare
- Update shell build options in angular.json to copy basic catalog assets and preserve symlinks. - Create symlink in shell/src/samples to work around Angular CLI folder copying rules. - Set defaultRendererUrl in config.json to relative path. - Add basic catalog workspace dependency to shell package.json for build ordering, and build catalog workspace on shell start. - Configure ng-basic-catalog build with relative base href to support embedded frame loading. - Resolve preview-bridge catalog endpoints relatively to support embedded paths. - Relax settings page pattern validator and QueryParser URL parser to support relative paths. - Add E2E and unit tests verifying relative URL resolution, validation, and initial workspace loading. - Restrict CAR_BOOKING pre-population to when the renderer app supports the basic catalog. - Update StateSync to dynamically detect catalog changes and reset the active draft if incompatible. - Safely serialize catalog initial drafts using JSON.stringify. - Change start script in shell package.json to use standard yarn for improved portability. - Add unit tests for StateSync to cover dynamic draft resets on catalog change and verify parsing logic edge cases. - Fix failing React basic catalog test to expect relative path 'catalog' fetch. TAG=agy BUG=
1 participant
Description
Include the ng-basic-catalog sample in with the shell build so that you can be up & running immediately.
Pre-launch Checklist