Point eight samples at the new walkthrough tutorial - #794
Merged
Conversation
abap2UI5/docs grew a Tutorials section whose walkthrough builds a small
invoice app in eight steps, and each step page declares the sample that
demonstrates the same thing in a finished app. `" @docs` is the other
half of that pairing: link-samples.mjs over there fails when a page links
a class that does not point back, and check:docs-links here fails when a
line names a page that does not declare the class.
step 1 493 Basics I - Hello World, the Smallest App
step 3 495 Basics III - Lifecycle: Init, Event, Navigated
004 Basics IV - Events, Views and Roundtrips
step 4 494 Basics II - Data Binding: Input and Button
step 5 048 StandardListItem, Highlight and Events
step 6 167 Extra Arguments with t_arg
step 7 012 Ways to Open a Dialog
step 8 070 Full Example with sap.ui.table
048 had no `" @docs` line at all and gets its first; the other seven
append to the line they already carried. SAMPLES.md is regenerated,
which is where these links are rendered.
Note for merge order: check:docs-links resolves abap2UI5/docs from a
sibling checkout when there is one and from raw main otherwise, so on CI
this passes once the documentation side is merged. It is green here
against the branch that carries those pages.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PwxPfiy5WE8fVxfnToFeWk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
abap2UI5/docs grew a Tutorials section whose walkthrough builds a small invoice app in eight steps, and each step page declares the sample that demonstrates the same thing in a finished app.
" @docsis the other half of that pairing:link-samples.mjsover there fails when a page links a class that does not point back, andcheck:docs-linkshere fails when a line names a page that does not declare the class.The pairing
Z2UI5_CL_SMP_APP_493Z2UI5_CL_SMP_APP_495Z2UI5_CL_SMP_APP_004Z2UI5_CL_SMP_APP_494Z2UI5_CL_SMP_APP_048Z2UI5_CL_SMP_APP_167Z2UI5_CL_SMP_APP_012Z2UI5_CL_SMP_APP_070048had no" @docsline at all and gets its first; the other seven append to the line they already carried. Step 2 gets none on purpose — Basics I is the only "a first view" sample here and it already stands at step 1.SAMPLES.mdis regenerated (npm run launchpad), which is where these links are rendered.Merge order
check:docs-linksresolves abap2UI5/docs from a sibling checkout when there is one and from rawmainotherwise, so on CI this passes once the documentation side is merged. Merge abap2UI5/docs#171 first. It is green here against the branch that carries those pages.Verification
npm run checkgreen end to end:check:pin,lint,check:cloud,check:abap2ui5,check:agents,check:strip,check:keywords,check:launchpad,check:overview,check:prose,check:docs-links(97 classes → 46 pages, every link resolves and points at a page that names it back),check:app-rules,check:family-nav,rename.🤖 Generated with Claude Code
https://claude.ai/code/session_01PwxPfiy5WE8fVxfnToFeWk
Generated by Claude Code