Point 011 and 070 at the walkthrough steps that now exist, and two stale statements - #798
Merged
Merged
Conversation
… "two-way" #796 moved the two `" @docs` lines to walkthrough steps 8 to 10, on the expectation that abap2UI5/docs#171 would create them. Docs took a different route: the walkthrough ends at step 8 (App Structure), and `get_started/full_example` - the page #796 dropped - is still there and still declares both classes in its `samples:` frontmatter. So both sides were red. The links now say what is actually published: - 011 -> `get_started/full_example`, `cookbook/model/tables` - 070 -> the same two plus `tutorials/walkthrough/step-8`, whose frontmatter names 070 `check:docs-links` here and `check:samples` in abap2UI5/docs are both green again, and SAMPLES.md is regenerated. Two more, unrelated: - 448's comment called `_bind( )` a "two-way binding", which AGENTS.md §2 asks nobody to do - in comments as much as in titles. - `generate-samples-md.mjs` said "three classes in src/00/98 ... are data objects". There are two, and the file already renders the count from `dataObjects` a few lines down, so the comment now points at that instead of repeating a number that goes stale. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XJBaqq5cFVUVMGr1BQvSVC
The client-API table told an agent that "history back rides `follow_up_action( cs_event-history_back )`". That constant is gone from `z2ui5_if_client` since 1.143.0 - the release this repository pins - so code written from that line does not compile. Nothing caught it: check:prose resolves class NAMES, not constants. Replaced with what app 322 in this repository actually does (the raw `history.back()` handed to `follow_up_action( )`), plus `nav_app_leave( )` for going back inside the app, and the routing entry spelled the way the framework takes it today. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XJBaqq5cFVUVMGr1BQvSVC
…erungen-fixes-ovyryc
When I changed these two `" @docs` lines, `get_started/full_example` still existed and the walkthrough ended at step 8, so pointing there was what resolved. abap2UI5/docs has since done what #796 expected: the walkthrough grew to ten steps, Full Example was folded into them and the page is gone. So the targets go back to exactly what #796 wrote, and they now resolve on both sides: - 011 -> step-8 (selection screen) and step-10 (the finished app) - 070 -> step-9 (tables) and step-10 Each of those pages names the class back in its `samples:` frontmatter. check-docs-links is green against the docs checkout, and SAMPLES.md is regenerated. The other two fixes from that commit are untouched: 448's comment no longer says "two-way", and generate-samples-md.mjs no longer states a data-object count that goes stale. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XJBaqq5cFVUVMGr1BQvSVC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small, unrelated corrections found by reading this repository against the framework and against abap2UI5/docs.
" @docsof 011 and 070. #796 aimed them at walkthrough steps 8–10 on the expectation that abap2UI5/docs would create those pages. It has since done exactly that (the walkthrough grew to ten steps andget_started/full_examplewas folded into them), so the two lines now resolve on both sides:011→cookbook/model/tables,tutorials/walkthrough/step-8,tutorials/walkthrough/step-10070→cookbook/model/tables,tutorials/walkthrough/step-9,tutorials/walkthrough/step-10Each of those pages names the class back in its
samples:frontmatter.SAMPLES.mdis regenerated.AGENTS.mdnamed a constant that 1.143.0 removed. The client-API table said history back "ridesfollow_up_action( cs_event-history_back )". That constant is gone fromz2ui5_if_clientin the release this repository pins, so code written from that line does not compile. It now says what app 322 in this repository actually does — the rawhistory.back()handed tofollow_up_action( )— plusnav_app_leave( )for going back inside the app. Nothing caught this:check:proseresolves class names, not constants.Two more. App 448's comment called
_bind( )a "two-way binding", which AGENTS.md §2 asks nobody to do, in comments as much as in titles. Andgenerate-samples-md.mjssaid "three classes in src/00/98 … are data objects"; there are two, and the file already renders the count fromdataObjectsa few lines down — the comment now points there instead of repeating a number that goes stale.How to test
npm run check— in particularcheck:docs-links, which needs anabap2UI5/docscheckout and is what verifies the two@docslines against the pages and their frontmatter.Checklist
npm run checkpasses (abaplint 0 issues over 307 files;check-docs-linksgreen, 97 classes → 47 pages)SAMPLES.md, launchpad and overview index verify clean)@docslines, two commentsGenerated by Claude Code