Skip to content

fix: app ready endpint function, import mongoose #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abushayedgit merged 1 commit into from
Sep 9, 2026
Merged

fix: app ready endpint function, import mongoose #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 37 additions & 38 deletions src/app/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,18 @@
import express from "express";
import helmet from "helmet";
import cors from "cors";
import { env } from "../config/env.js";
import { requestIdMiddleware } from "../middlewares/requestId.middleware.js";
import { requestLoggerMiddleware } from "../middlewares/requestLogger.middleware.js";
import { errorHandlerMiddleware } from "../middlewares/errorHandler.middleware.js";
import express from 'express';
import helmet from 'helmet';
import cors from 'cors';
import { env } from '../config/env.js';
import { requestIdMiddleware } from '../middlewares/requestId.middleware.js';
import { requestLoggerMiddleware } from '../middlewares/requestLogger.middleware.js';
import { errorHandlerMiddleware } from '../middlewares/errorHandler.middleware.js';
import {
securityHeadersMiddleware,
sanitizeRequestMiddleware,
} from "../middlewares/security.middleware.js";
import { globalRateLimiter } from "../middlewares/rateLimiter.middleware.js";
import { apiRoutes } from "./routes.js";
import {
setCsrfCookie,
csrfProtection,
} from "../middlewares/csrf.middleware.js";
} from '../middlewares/security.middleware.js';
import { globalRateLimiter } from '../middlewares/rateLimiter.middleware.js';
import { apiRoutes } from './routes.js';
import { setCsrfCookie, csrfProtection } from '../middlewares/csrf.middleware.js';
import mongoose from 'mongoose';

const app = express();

Expand All @@ -25,74 +23,75 @@ app.use(
cors({
origin: env.CORS_ORIGINS,
credentials: true,
methods: ["GET", "POST", "PUT", "PATCH", "DELETE", "OPTIONS"],
allowedHeaders: ["Content-Type", "Authorization", "x-request-id"],
methods: ['GET', 'POST', 'PUT', 'PATCH', 'DELETE', 'OPTIONS'],
allowedHeaders: ['Content-Type', 'Authorization', 'x-request-id'],
}),
);

app.use(requestIdMiddleware);
app.use(requestLoggerMiddleware);

app.use(express.json({ limit: "1mb" }));
app.use(express.urlencoded({ extended: true, limit: "1mb" }));
app.use(express.json({ limit: '1mb' }));
app.use(express.urlencoded({ extended: true, limit: '1mb' }));

app.use(sanitizeRequestMiddleware);
app.use(globalRateLimiter);

app.use("/api/v1", apiRoutes);
app.use('/api/v1', apiRoutes);

app.get("/health", (req, res) => {
app.get('/health', (req, res) => {
return res.status(200).json({
success: true,
statusCode: 200,
code: "OK",
message: "Server is healthy",
code: 'OK',
message: 'Server is healthy',
data: {
uptime: process.uptime(),
timestamp: new Date().toISOString(),
},
});
});

app.get("/ready", async (req, res) => {
app.get('/ready', async (req, res) => {
try {
const { checkRedis } = await import("../config/redis.js");
const { checkRedis } = await import('../config/redis.js');
const dbConnected = mongoose.connection.readyState === 1;
const redisOk = await checkRedis();

if (dbConnected) {
return res.status(200).json({
success: true,
statusCode: 200,
code: "OK",
message: "Server is ready",
code: 'OK',
message: 'Server is ready',
data: {
dependencies: {
mongodb: "connected",
redis: redisOk ? "connected" : "unavailable",
mongodb: 'connected',
redis: redisOk ? 'connected' : 'unavailable',
},
},
});
} else {
return res.status(503).json({
success: false,
statusCode: 503,
code: "NOT_READY",
message: "Server is not ready",
code: 'NOT_READY',
message: 'Server is not ready',
data: {
dependencies: {
mongodb: "disconnected",
redis: redisOk ? "connected" : "unavailable",
mongodb: 'disconnected',
redis: redisOk ? 'connected' : 'unavailable',
},
},
});
}
} catch (err) {
console.log(err);
return res.status(503).json({
success: false,
statusCode: 503,
code: "NOT_READY",
message: "Dependency check failed",
code: 'NOT_READY',
message: 'Dependency check failed',
});
}
});
Expand All @@ -101,8 +100,8 @@ app.use((req, res) => {
return res.status(404).json({
success: false,
statusCode: 404,
code: "NOT_FOUND",
message: "Route not found",
code: 'NOT_FOUND',
message: 'Route not found',
});
});

Expand All @@ -112,6 +111,6 @@ app.use(errorHandlerMiddleware);
app.use(setCsrfCookie);

// Apply CSRF protection to auth refresh endpoints
app.use("/api/v1/auth/admin/refresh", csrfProtection);
app.use("/api/v1/auth/user/refresh", csrfProtection);
app.use('/api/v1/auth/admin/refresh', csrfProtection);
app.use('/api/v1/auth/user/refresh', csrfProtection);
export default app;