Keep isFinished() false on StreamLog until stdin is closed#14
Open
jonscheiding wants to merge 1 commit into
Open
Keep isFinished() false on StreamLog until stdin is closed#14jonscheiding wants to merge 1 commit into
jonscheiding wants to merge 1 commit into
Conversation
Owner
|
Hi. I tried it out and it seemed to work, I made a few comments. |
Owner
|
Thought more about this. Without a Windows implementation of isPipeOpen() I think the change to Gource might break streaming on Windows (re your I wonder if there are other poll() statuses to make sure the pipe is valid. Changing the isFinished() might have other unexpected side effects elsewhere. |
Exposes a non-blocking check for whether the stdin pipe is still connected, so callers can distinguish a stream that's transiently empty from one whose peer has closed the pipe. POSIX uses poll(POLLIN) and treats POLLHUP/POLLERR/POLLNVAL as closed; Windows uses PeekNamedPipe (matching getNextLine). isFinished() is intentionally left unchanged.
Author
|
@acaudwell Revisiting this - thanks for the feedback and patience! I reworked this to be less invasive.
If you merge this, I'll resubmit my change in acaudwell/Gource to make use of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
isFinished()method onStreamLogreturnstruewhen the stream is empty. Attempting to modify it so that (at least on POSIX platforms) it can only returntruewhen the stream actually closes.