[mlir][dxsa] Add topology instructions#198
Open
dzhidzhoev wants to merge 5 commits into
Open
Conversation
Example: dxsa.cut dxsa.emit dxsa.emit_then_cut dxsa.emit_stream 1 dxsa.cut_stream 3 dxsa.emit_then_cut_stream 2
dzhidzhoev
force-pushed
the
users/dzhidzhoev/mlir/emitcut
branch
from
73b0263 to
2c32aeb
Compare
hvdijk
reviewed
Jun 24, 2026
| // dxsa.emit_then_cut | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| def DXSA_EmitThenCut : DXSA_NullaryOp<"emit_then_cut"> { |
Contributor
There was a problem hiding this comment.
Microsoft call this emitThenCut rather than emit_then_cut, likewise for emitThenCut_stream, is it possible to use their name or does it need to be this?
There was a problem hiding this comment.
Instruction names in Microsoft's specification are formed according to different naming rules, rather than following a single uniform convention. We decided to use snake_case for operation names to maintain consistency across the dialect.
tagolog
reviewed
Jun 25, 2026
| @@ -0,0 +1,154 @@ | |||
| //===- DXSTopologyOps.td - DXSA topology ops ---------------*- tablegen -*-===// | |||
There was a problem hiding this comment.
Suggested change
| //===- DXSTopologyOps.td - DXSA topology ops ---------------*- tablegen -*-===// | |
| //===- DXSATopologyOps.td - DXSA topology ops ---------------*- tablegen -*-===// |
tagolog
reviewed
Jun 25, 2026
| // CHECK-NEXT: dxsa.emit_stream 0 | ||
| 0x03000075, 0x00110000, 0x00000000 | ||
|
|
||
| // CHECK-NEXT: dxsa.emit_stream 1 |
There was a problem hiding this comment.
Redundant: all three stream ops decode the index through the same path. Maybe we can keep happy path for boundaries only (0 and 3)?
Contributor
Author
There was a problem hiding this comment.
Sure, fixed that.
tagolog
reviewed
Jun 25, 2026
| // CHECK-NEXT: dxsa.emit_stream 1 | ||
| 0x03000075, 0x00110000, 0x00000001 | ||
|
|
||
| // CHECK-NEXT: dxsa.emit_stream 2 |
tagolog
reviewed
Jun 25, 2026
| // CHECK-NEXT: dxsa.cut_stream 0 | ||
| 0x03000076, 0x00110000, 0x00000000 | ||
|
|
||
| // CHECK-NEXT: dxsa.cut_stream 1 |
tagolog
reviewed
Jun 25, 2026
| // CHECK-NEXT: dxsa.cut_stream 1 | ||
| 0x03000076, 0x00110000, 0x00000001 | ||
|
|
||
| // CHECK-NEXT: dxsa.cut_stream 2 |
tagolog
reviewed
Jun 25, 2026
| // CHECK-NEXT: dxsa.emit_then_cut_stream 0 | ||
| 0x03000077, 0x00110000, 0x00000000 | ||
|
|
||
| // CHECK-NEXT: dxsa.emit_then_cut_stream 1 |
tagolog
reviewed
Jun 25, 2026
| // CHECK-NEXT: dxsa.emit_then_cut_stream 1 | ||
| 0x03000077, 0x00110000, 0x00000001 | ||
|
|
||
| // CHECK-NEXT: dxsa.emit_then_cut_stream 2 |
tagolog
requested changes
Jun 25, 2026
hvdijk
reviewed
Jun 25, 2026
| // DXSA shared bases for ops with inline operands | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| class DXSA_NullaryOp<string mnemonic> : DXSA_Op<mnemonic> { |
Contributor
There was a problem hiding this comment.
This is identical to what is in #194; I'm not sure which PR had it first and where the review comment should go. Regardless, the same comment applies here.
hvdijk
requested changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example:
dxsa.cut
dxsa.emit
dxsa.emit_then_cut
dxsa.emit_stream 1
dxsa.cut_stream 3
dxsa.emit_then_cut_stream 2