Skip to content

[mlir][dxsa] Add nop instruction #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dzhidzhoev wants to merge 1 commit into
base: users/dzhidzhoev/mlir/emitcut
Choose a base branch
from
+24 −0
Open

[mlir][dxsa] Add nop instruction #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions mlir/include/mlir/Dialect/DXSA/IR/DXSAOps.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1369,4 +1369,17 @@ def DXSA_DclThreadGroup : DXSA_Op<"dcl_thread_group"> {
let hasVerifier = 1;
}

def DXSA_Nop : DXSA_NullaryOp<"nop"> {
let summary = "no operation";
let description = [{
The `dxsa.nop` operation has no effect.

Example:

```mlir
dxsa.nop
```
}];
}

#endif // DXSA_OPS
2 changes: 2 additions & 0 deletions mlir/lib/Target/DXSA/BinaryParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2435,6 +2435,8 @@ class Parser {
return PLAIN_OP(UShr, 1, 2);
case D3D10_SB_OPCODE_XOR:
return PLAIN_OP(Xor, 1, 2);
case D3D10_SB_OPCODE_NOP:
return PLAIN_OP(Nop, 0, 0);
case D3D10_SB_OPCODE_EMIT:
return PLAIN_OP(Emit, 0, 0);
case D3D10_SB_OPCODE_EMITTHENCUT:
Expand Down
9 changes: 9 additions & 0 deletions mlir/test/Target/DXSA/nop.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// RUN: mlir-translate --import-dxsa-hex %s | FileCheck %s
// RUN: mlir-translate --import-dxsa-hex %s | mlir-opt --verify-roundtrip

// CHECK: dxsa.module {

// CHECK-NEXT: dxsa.nop
0x0100003A

// CHECK-NEXT: }