Skip to content

Add slippage impact override protection - #1008

Merged
Chucks1093 merged 1 commit into
accesslayerorg:devfrom
Gojv-byte:Add-slippage-protection-warning-and-override-on-large-trade-execution
Sep 27, 2026
Merged

Chucks1093 merged 1 commit into
accesslayerorg:devfrom
Gojv-byte:Add-slippage-protection-warning-and-override-on-large-trade-execution

Conversation

@Gojv-byte

Copy link
Copy Markdown
Contributor

Summary

  • Persist the slippage tolerance preference (1% default).
  • Show a live price-impact warning when impact exceeds tolerance; require acknowledgement before submitting.
  • Add coverage for preference persistence and buy/sell trade flows.

closes #995

Testing

  • pnpm lint
  • pnpm build
  • Focused trade and preference tests (41 passed)
  • Full pnpm test (130 tests failed across 50 files)

Checklist

  • Linked issue or backlog item
  • Scope is limited to the stated change
  • Updated docs if behavior or setup changed
  • Added screenshots for UI changes when relevant

@drips-wave

drips-wave Bot commented Sep 26, 2026

Copy link
Copy Markdown

@Gojv-byte Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Chucks1093
Chucks1093 merged commit abfffff into accesslayerorg:dev Sep 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add slippage protection warning and override on large trade execution

2 participants