Skip to content

feat: initialize creator keys from factory config - #1007

Merged
Chucks1093 merged 3 commits into
accesslayerorg:mainfrom
nasirudeenbadirudeen87-cloud:fix/issue-995
Sep 28, 2026
Merged

Chucks1093 merged 3 commits into
accesslayerorg:mainfrom
nasirudeenbadirudeen87-cloud:fix/issue-995

Conversation

@nasirudeenbadirudeen87-cloud

Copy link
Copy Markdown

Summary

  • add a typed deployment configuration for creator key factory calls
  • validate creator handle, supply, wallet-cap, and curve inputs before deployment
  • deploy, initialize, register, index, and emit the key in one transaction

Verification

  • cargo check -p creator-keys-factory

Fixes #995

@drips-wave

drips-wave Bot commented Sep 27, 2026

Copy link
Copy Markdown

@nasirudeenbadirudeen87-cloud Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@nasirudeenbadirudeen87-cloud

Copy link
Copy Markdown
Author

@accesslayerorg @nasirudeenbadirudeen87-cloud The atomic creator-key deployment path is complete in commit b75c82c11bdd2324b8010b0ae9deb0ef14557755. It validates the creator handle, supply cap, wallet cap, and curve preset before deploying, initializes the child contract, records creator-ordered registry entries, and emits the deployment event. Verification: cargo check -p creator-keys-factory passed. The PR references Fixes #995. Please review and merge when CI is green.

@nasirudeenbadirudeen87-cloud

Copy link
Copy Markdown
Author

The CI failure was only Rust formatting in creator-keys-factory/src/lib.rs. I formatted the file and pushed commit d8b1ddb to fix/issue-995; please rerun the verification workflow.

@nasirudeenbadirudeen87-cloud

Copy link
Copy Markdown
Author

The formatting fix is pushed as d8b1ddb. The latest verification check is still failing, so this is no longer a cargo-fmt-only issue; please inspect the fresh verification log and rerun after addressing the remaining repository check failure.

@nasirudeenbadirudeen87-cloud

Copy link
Copy Markdown
Author

The remaining verification failure was Clippy’s len_zero lint on config.handle.len() == 0. Replaced it with config.handle.is_empty() and pushed 0f01968. Please rerun CI.

@Chucks1093
Chucks1093 merged commit 5b7e5c4 into accesslayerorg:main Sep 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add key factory contract for standardised creator key deployment

3 participants