feat: add timelock contract for delayed admin actions - #1011
Open
bright5455 wants to merge 1 commit into
Open
bright5455 wants to merge 1 commit into
bright5455 wants to merge 1 commit into
Conversation
|
@bright5455 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #986
Summary
Adds a
timelockSoroban contract that wraps privileged admin operations with a mandatory delay, letting the community observe and cancel actions before they execute.Scope
queue_action(action_type, params, eta)— enforceseta >= now + min_delayexecute_action(action_id)— only aftereta, otherwiseTimeRemainingcancel_action(action_id)— admin onlyget_queued_actions()— returns all pending actions withetaandparamsAcceptance criteria
execute_actionblocked beforeeta→TimelockError::TimeRemainingTimelockError::MinDelayNotMetget_queued_actionsreturns correct params + etaActionQueued/ActionExecutedevents emitted (plusActionCancelled)Tests
cargo test -p timelock→ 9 passed, 0 failed. Clippy clean with-D warnings.Files
timelock/Cargo.toml(new)timelock/src/lib.rs(new, ~410 LOC incl. tests)timelock/test_snapshots/test/*.json(auto-generated, 9 files)Cargo.toml(addtimelockto workspace members)Cargo.lock(cargo update)