feat: implement multisig proposal queue API (#961) - #977
Merged
Chucks1093 merged 3 commits intoSep 28, 2026
Merged
Chucks1093 merged 3 commits into
Chucks1093 merged 3 commits into
Conversation
- Add MultisigProposal and MultisigSignature Prisma models with migration - Implement GET /admin/proposals (paginated queue with status filter) - Implement GET /admin/proposals/:id (detailed view with all signatures) - Implement POST /admin/proposals/:id/sign (submit signature with threshold execution) - Implement POST /admin/proposals/:id/reject (reject proposal with rejector/timestamp) - Use ADMIN_MULTISIG_WALLETS for signer authorization (2-of-3 default) - Prevent duplicate signatures with DB unique constraint - Atomic threshold execution with DB transactions - Comprehensive integration and unit tests - Update API documentation
zainabwahab-eth
force-pushed
the
feat/961-multisig-proposal-queue
branch
from
September 27, 2026 09:53
62c0ee3 to
153850d
Compare
|
@zainabwahab-eth Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #961
Summary
Implements the multi-sig proposal queue API for managing admin proposals requiring multi-sig approval.
Endpoints Implemented
Key Features
ADMIN_MULTISIG_WALLETSenv config (2-of-3 default) for authorizationDatabase Changes
multisig_proposalstable with proposal metadata, status, threshold, proposermultisig_signaturestable with foreign key to proposals, unique constraint on (proposalId, signer)20260927000000_add_multisig_proposal_queueTests
Documentation
docs/api-endpoints.mdwith all new endpoints, request/response examples, and error codes