feat!: typescript overhaul and amd rules decouple

.github/workflows/ci.yml

@@ -1,28 +1,36 @@
 name: CI
 
-on:
-  push:
-  pull_request:
+on: [push, pull_request]
 
 jobs:
   lint:
-    name: Check linting and formatting
+    name: Check linting, formatting, types
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-node@v4
+      - uses: actions/checkout@v7
+      - uses: pnpm/action-setup@v6
+        with:
+          version: 11
+      - uses: actions/setup-node@v7
+        with:
+          node-version: 24
       - run: |
-          yarn
-          yarn prettier . --debug-check
-      - run: |
-          yarn lint
+          pnpm install
+          pnpm check
+          pnpm check:types
 
   test:
     name: Test rules
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-node@v4
+      - uses: actions/checkout@v7
+      - uses: pnpm/action-setup@v6
+        with:
+          version: 11
+      - uses: actions/setup-node@v7
+        with:
+          node-version: 24
       - run: |
-          yarn
-          yarn test
+          pnpm install
+          pnpm test
+          pnpm test:e2e

README.md

@@ -46,30 +46,18 @@ export default [
 ];
 ```
 
-## Migration from v1.x
+## Upgrading
 
-v2 is **flat-config only**. To migrate:
-
-- Replace `.eslintrc.*` with `eslint.config.js`.
-- Replace `extends: ['plugin:suitescript/recommended']` with `...suitescript.configs.recommended` (spread).
-- Replace `env: { 'suitescript/suitescript2': true }` with `...suitescript.configs.suitescript2`.
-- Bump `eslint` to `>= 9` in your project.
-
-`configs.recommended` already declares the AMD globals (`define`, `require`) and the standard browser globals (`window`, `document`, ...) that v1's `env: { amd: true, browser: true }` provided, so `no-undef` keeps working on `define([...], function() {})` modules and on client scripts that touch the DOM.
-
-Stay on `eslint-plugin-suitescript@^1` if you cannot migrate.
+See the [upgrade guide](docs/upgrade.md) for details on upgrading the package to a new major version.
 
 ## List of supported rules
 
 - [suitescript/api-version](docs/rules/api-version.md): Enforces valid `@NApiVersion` tag values
 - [suitescript/entry-points](docs/rules/entry-points.md): Enforces inclusion of at least one entry point based on `@NScriptType`
 - [suitescript/log-args](docs/rules/log-args.md): Enforces correct log arguments
 - [suitescript/module-vars](docs/rules/module-vars.md): Enforces correct module identifiers for each configured module
-- [suitescript/no-amd-name](docs/rules/no-amd-name.md): Restricts naming of AMD modules
-- [suitescript/no-extra-modules](docs/rules/no-extra-modules.md): Enforces equal number of module literals and identifiers
 - [suitescript/no-invalid-modules](docs/rules/no-invalid-modules.md): Enforces valid SuiteScript modules in `define` array
 - [suitescript/no-log-module](docs/rules/no-log-module.md): Restricts loading of the N/log module in favor of global `log`
-- [suitescript/no-module-extensions](docs/rules/no-module-extensions.md): Restricts filename extensions on module dependencies
 - [suitescript/script-type](docs/rules/script-type.md): Enforces valid `@NScriptType` tag values
 
 ## License

biome.json

@@ -0,0 +1,37 @@
+{
+  "$schema": "./node_modules/@biomejs/biome/configuration_schema.json",
+  "vcs": {
+    "enabled": true,
+    "clientKind": "git",
+    "useIgnoreFile": true
+  },
+  "files": {
+    "ignoreUnknown": false
+  },
+  "formatter": {
+    "enabled": true,
+    "indentStyle": "space"
+  },
+  "linter": {
+    "enabled": true,
+    "rules": {
+      "preset": "recommended",
+      "suspicious": {
+        "useIterableCallbackReturn": "off"
+      }
+    }
+  },
+  "javascript": {
+    "formatter": {
+      "quoteStyle": "single"
+    }
+  },
+  "assist": {
+    "enabled": true,
+    "actions": {
+      "source": {
+        "organizeImports": "on"
+      }
+    }
+  }
+}

docs/rules/module-vars.md

@@ -71,7 +71,9 @@ Specify at least one module name with a corresponding variable name.
 - N/https
 - N/https/clientCertificate
 - N/keyControl
+- N/llm
 - N/log
+- N/pgp
 - N/piremoval
 - N/plugin
 - N/portlet