Repository navigation
DEVXPT-35: Device code flow implementation #2049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bansodejoyce
wants to merge
17
commits into
acquia:main
Choose a base branch
from
bansodejoyce:feature/device-code-flow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
08407f1
enabled device-code for authentication
bansodejoyce 45f06cf
work on token refresh
bansodejoyce 076929c
error handling added
bansodejoyce ef131ee
log for error handling
bansodejoyce 71c8813
addressed browser auto-open gap
bansodejoyce 678be26
Addresses review findings 1-5 and 7-10 on this PR
bansodejoyce 8f77521
addressed the CI patchcov
bansodejoyce 5bdcefb
resolve mutation testing
bansodejoyce 16fd69c
added mutation testing scenario
bansodejoyce 3e52622
added mutation testing scenario
bansodejoyce 68eeacd
mutation testing scenario
bansodejoyce 84f5259
mutation testing scenario for client service
bansodejoyce 6dd45f5
Merge branch 'main' into feature/device-code-flow
bansodejoyce 3609e67
revised convention
bansodejoyce bfa337e
Merge branch 'main' into feature/device-code-flow
bansodejoyce 9ef74fd
addressed in-memory datastore
bansodejoyce c0fecfa
Merge branch 'feature/device-code-flow' of github.com:bansodejoyce/cl…
bansodejoyce File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| BUGSNAG_KEY=abcd1234 | ||
| AMPLITUDE_KEY=acbd1234 | ||
| ACLI_VERSION=1.0.0 | ||
| ACLI_DEVICE_CLIENT_ID=0oa1example2client3id | ||
| ACLI_AUTH_DOMAIN=example.acquia.com | ||
| ACLI_AUTH_SERVER_ID=ausExample1234 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Acquia\Cli\CloudApi; | ||
|
|
||
| /** | ||
| * Authorization-server configuration for the device code flow , | ||
| * shared by login and token refresh. | ||
| */ | ||
| class AuthConfig | ||
| { | ||
| public function authServerId(): string | ||
| { | ||
| return getenv('ACLI_AUTH_SERVER_ID') ?: ''; | ||
| } | ||
|
|
||
| public function clientId(): string | ||
| { | ||
| return getenv('ACLI_DEVICE_CLIENT_ID') ?: ''; | ||
| } | ||
|
|
||
| public function domain(): string | ||
| { | ||
| return getenv('ACLI_AUTH_DOMAIN') ?: ''; | ||
| } | ||
|
|
||
| public function isConfigured(): bool | ||
| { | ||
| return $this->clientId() !== '' | ||
| && $this->domain() !== '' | ||
| && $this->authServerId() !== ''; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.