Repository navigation
Update Cloud Platform API spec - #2051
Open
PrakharJainS3 wants to merge 1 commit into
Open
PrakharJainS3 wants to merge 1 commit into
PrakharJainS3 wants to merge 1 commit into
Conversation
Regenerate assets/acquia-spec.json via `composer update-cloud-api-spec` (cx-api-spec 54fba48 -> cc4a637). Update the trusted-proxies test to match the renamed command (environments:trusted-proxies -> environments:find-trusted-proxies) and the new response shape (cidrs_ipv4/cidrs_ipv6/associated_cdns replacing is_enabled/addresses). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/2051/acli.phar |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The full specification diff was not supplied, so its generated-command changes still require verification.
0 open findings
What changed in this PR
Tracks the upstream Cloud Platform API spec refresh and aligns the generated-command regression test.
Changes:
- Advances the recorded upstream revision to
cc4a637. - Updates the trusted-proxies test for the renamed command and new response fields.
| File | Description |
|---|---|
| tests/phpunit/src/Commands/Api/ApiCommandTest.php | Updates the command name, mock response, and assertions. |
| assets/acquia-spec.version | Records the refreshed upstream revision. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2051 +/- ##
=========================================
Coverage 92.77% 92.77%
Complexity 2037 2037
=========================================
Files 126 126
Lines 7345 7345
=========================================
Hits 6814 6814
Misses 531 531 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
itafroma
approved these changes
Oct 8, 2026
ndelrossi
approved these changes
Oct 8, 2026
abarriosr
approved these changes
Oct 8, 2026
bansodejoyce
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Keep the local copy of the Cloud Platform API spec (
assets/acquia-spec.json) in sync with upstreamcx-api-spec, per CONTRIBUTING.md. The spec had not been refreshed since cx-api-spec commit54fba484c9feb5d0ed8677801be31e14d2e3278b.Proposed changes
assets/acquia-spec.jsonandassets/acquia-spec.versionviacomposer update-cloud-api-spec(cx-api-spec54fba48->cc4a637).environments:trusted-proxiestest to follow upstream's rename toenvironments:find-trusted-proxiesand its new response shape (cidrs_ipv4/cidrs_ipv6/associated_cdnsreplacingis_enabled/addresses).api:environments:trusted-proxiesis renamed toapi:environments:find-trusted-proxiesas a result of the upstream spec change.Alternatives considered
N/A — this is a routine spec sync per the documented process.
Testing steps
./bin/acli ckccomposer test(lint, phpcs, phpstan, full PHPUnit suite) passes locally../bin/acli api:environments:find-trusted-proxies --helpreflects the renamed command and updated response fields.🤖 Generated with Claude Code