Repository navigation
Proposed checksum verification - #2053
Open
bansodejoyce wants to merge 3 commits into
Open
bansodejoyce wants to merge 3 commits into
bansodejoyce wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The workflow consistently validates all release artifacts and handles non-tagged builds correctly.
0 open findings
What changed in this PR
Adds SHA-256 integrity verification and publishing to the release workflow.
Changes:
- Uploads platform-specific native tarballs.
- Generates and verifies
SHA256SUMSagainst release assets. - Includes checksum validation in the aggregate check.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Adds checksum generation, verification, publication, and job coordination. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2053 +/- ##
=========================================
Coverage 92.77% 92.77%
Complexity 2037 2037
=========================================
Files 126 126
Lines 7345 7345
=========================================
Hits 6814 6814
Misses 531 531 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/2053/acli.phar |
ndelrossi
approved these changes
Oct 14, 2026
PrakharJainS3
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the GitHub Actions CI workflow to improve the release process by adding a checksum verification and publishing step for release artifacts. The main changes are the introduction of a new
build-checksumsjob, adjustments to artifact handling, and updates to the overall workflow to ensure checksum validation and attachment to releases.Release process improvements:
build-checksumsjob that generates a SHA256 checksum manifest for release artifacts, verifies the checksums against published assets, and attaches the checksum file (SHA256SUMS) to the GitHub release. This job ensures the integrity of release assets and provides users with a manifest to verify downloads.build-nativejob to use platform-specific tarballs (native-acli-${{ matrix.platform }}.tar.gz) instead of a genericacliartifact, aligning artifact names and formats with release assets.Workflow coordination:
checkjob to includebuild-checksumsas a required dependency, but allowed it to be skipped for non-tagged builds (e.g., PRs and pushes), ensuring it only runs for actual releases.Testing steps
./bin/acli ckc