Skip to content

Proposed checksum verification - #2053

Open
bansodejoyce wants to merge 3 commits into
acquia:mainfrom
bansodejoyce:feature/checksum-build
Open

bansodejoyce wants to merge 3 commits into
acquia:mainfrom
bansodejoyce:feature/checksum-build

Conversation

@bansodejoyce

Copy link
Copy Markdown

This pull request updates the GitHub Actions CI workflow to improve the release process by adding a checksum verification and publishing step for release artifacts. The main changes are the introduction of a new build-checksums job, adjustments to artifact handling, and updates to the overall workflow to ensure checksum validation and attachment to releases.

Release process improvements:

  • Added a build-checksums job that generates a SHA256 checksum manifest for release artifacts, verifies the checksums against published assets, and attaches the checksum file (SHA256SUMS) to the GitHub release. This job ensures the integrity of release assets and provides users with a manifest to verify downloads.
  • Modified the artifact upload step in the build-native job to use platform-specific tarballs (native-acli-${{ matrix.platform }}.tar.gz) instead of a generic acli artifact, aligning artifact names and formats with release assets.

Workflow coordination:

  • Updated the check job to include build-checksums as a required dependency, but allowed it to be skipped for non-tagged builds (e.g., PRs and pushes), ensuring it only runs for actual releases.

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. If running from source, clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. Check for regressions: (add specific steps for this pr)
  4. Check new functionality: (add specific steps for this pr)

Copilot AI balanced review requested due to automatic review settings October 14, 2026 11:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The workflow consistently validates all release artifacts and handles non-tagged builds correctly.

0 open findings

What changed in this PR

Adds SHA-256 integrity verification and publishing to the release workflow.

Changes:

  • Uploads platform-specific native tarballs.
  • Generates and verifies SHA256SUMS against release assets.
  • Includes checksum validation in the aggregate check.
File Description
.github/​workflows/​ci.yml Adds checksum generation, verification, publication, and job coordination.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.77%. Comparing base (be153fc) to head (7fda3ec).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2053   +/-   ##
=========================================
  Coverage     92.77%   92.77%           
  Complexity     2037     2037           
=========================================
  Files           126      126           
  Lines          7345     7345           
=========================================
  Hits           6814     6814           
  Misses          531      531           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown
Contributor

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/2053/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/2053/acli.phar
chmod +x acli.phar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants