Add build workflow - #2
Merged
Merged
Conversation
Runs initialize-variables and checks its outputs. Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
The COMMIT_MESSAGE output referenced a step id that does not exist, so it was always empty. The push step's if: was nested under env:, so it ran on every event and shadowed the pull request path. The manual path read HEAD^2, which does not resolve on a branch head. Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs
./initialize-variableson push, pull request, and manual dispatch,then checks that
COMMIT_MESSAGEis non-empty andFULL_BUILDis a boolean.Writing this surfaced three problems in the action that the test does not
paper over:
if:is nested one level too deep — it sits underenv:instead of on the step. The step therefore runs on every event andsets an env var literally named
if. Because its output is first in the||chain forFULL_BUILD, it shadows the pull-request step, so[ci-full]in a PR title never takes effect.workflow_dispatchbranch readsgit log HEAD^2, which only resolveson a merge commit. A manual run on a branch head yields an empty
COMMIT_MESSAGE, so this workflow will fail when dispatched by hand untilthat is fixed.
fullinput is never referenced by any step, so passing ithas no effect. The manual path reads
github.event.inputs.ci-fullinstead.
Left alone here since they change behaviour.