Add dotnet-version: latest support with dotnet-channel input#730
Open
mahabaleshwars wants to merge 4 commits intoactions:mainfrom
Open
Add dotnet-version: latest support with dotnet-channel input#730mahabaleshwars wants to merge 4 commits intoactions:mainfrom
mahabaleshwars wants to merge 4 commits intoactions:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for dotnet-version: latest in the action by resolving the highest active .NET SDK channel via the .NET releases index API, with an optional dotnet-channel input to constrain the resolution. Updates the supported dotnet-quality values and refreshes docs/tests/e2e coverage accordingly.
Changes:
- Implement
latestresolution (with optionaldotnet-channel) and wire it through installer/version resolution. - Remove
signedandvalidatedfrom supporteddotnet-qualityvalues (nowdaily,preview,ga). - Update action metadata, documentation, unit tests, and e2e workflows for the new behavior.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/setup-dotnet.ts | Validates/handles dotnet-channel, normalizes latest, passes channel through to installer. |
| src/installer.ts | Adds latest resolution via releases index API and threads quality/dotnetChannel into resolver. |
| dist/setup/index.js | Compiled bundle reflecting the new resolver/channel logic. |
| action.yml | Documents latest, adds dotnet-channel input, updates dotnet-quality description. |
| tests/setup-dotnet.test.ts | Updates dotnet-quality expectations; adds dotnet-channel validation/warning tests. |
| tests/latest-version.test.ts | New unit tests for latest resolution and channel/quality filtering behavior. |
| tests/installer.test.ts | Adjusts tests to no longer depend on the removed QualityOptions import/casts. |
| README.md | Documents latest, dotnet-channel, and updated dotnet-quality behavior. |
| .github/workflows/e2e-tests.yml | Adds e2e coverage for latest; adjusts proxy test container and installs PowerShell. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Apr 16, 2026
|
Maybe worth checking dotnet/install-scripts#418 to either give feedback or otherwise just be aware of it. |
Frulfump
reviewed
Apr 16, 2026
|
Added an issue that tracks the failing pipeline due to npm audit failing |
…ersion test mocks
priya-kinthali
approved these changes
Apr 21, 2026
priyagupta108
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds
dotnet-version: latestsupport to automatically install the highest active .NET SDK via the releases index API. Introduces an optionaldotnet-channelinput (LTS,STS,A.B,A.B.Cxx) to filter the resolved version—ignored with a warning ifdotnet-versionisn'tlatest. Removessignedandvalidatedfromdotnet-quality, retaining onlydaily,preview, andga.Related issue:
#497
#640
Check list: