Skip to content

http-client: support CIDR in no_proxy #2495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
silverwind wants to merge 3 commits into
base: main
Choose a base branch
from
Open

http-client: support CIDR in no_proxy #2495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3654973
http-client: support CIDR ranges in no_proxy
silverwind Sep 15, 2026
8c28864
http-client: reject no_proxy CIDR entries with extra segments
silverwind Sep 15, 2026
ec78192
Apply suggestion from @silverwind
silverwind Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/http-client/__tests__/proxy.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,13 @@ describe('proxy', () => {
expect(bypass).toBeTruthy()
})

it('checkBypass supports CIDR in no_proxy', () => {
process.env['no_proxy'] = '10.0.0.0/8,fd00::/8,11.0.0.0/33,11.0.0.0/8/x'
expect(pm.checkBypass(new URL('http://10.1.2.3:8088'))).toBeTruthy()
expect(pm.checkBypass(new URL('http://[fd00::1]'))).toBeTruthy()
expect(pm.checkBypass(new URL('http://11.1.2.3'))).toBeFalsy()
})

it('checkBypass returns true if no_proxy is "*"', () => {
process.env['no_proxy'] = '*'
const bypass = pm.checkBypass(new URL('https://anything.whatsoever.com'))
Expand Down
18 changes: 17 additions & 1 deletion packages/http-client/src/proxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import {BlockList, isIP} from 'net'

export function getProxyUrl(reqUrl: URL): URL | undefined {
const usingSsl = reqUrl.protocol === 'https:'

Expand Down Expand Up @@ -69,7 +71,8 @@ export function checkBypass(reqUrl: URL): boolean {
x.endsWith(`.${upperNoProxyItem}`) ||
(upperNoProxyItem.startsWith('.') &&
x.endsWith(`${upperNoProxyItem}`))
)
) ||
matchesCidr(reqHost.replace(/^\[|\]$/g, ''), upperNoProxyItem)
) {
return true
}
Expand All @@ -88,6 +91,19 @@ function isLoopbackAddress(host: string): boolean {
)
}

function matchesCidr(ip: string, cidr: string): boolean {
const [network, prefix, extra] = cidr.split('/')
if (!prefix || extra !== undefined || !isIP(ip)) return false

const blockList = new BlockList()
try {
blockList.addSubnet(network, +prefix, isIP(network) === 6 ? 'ipv6' : 'ipv4')
return blockList.check(ip, isIP(ip) === 6 ? 'ipv6' : 'ipv4')
} catch {
return false
}
}

class DecodedURL extends URL {
private _decodedUsername: string
private _decodedPassword: string
Expand Down