Support linking against ada via feature#110
Merged
Merged
Conversation
anonrig
approved these changes
Jul 1, 2026
Member
|
Hi Logan! Is there a way to test this, so we don't regress? |
Member
|
Also can you update the README.md with this change? |
Contributor
Author
|
Hi Yagiz, I updated the existing feature powerset to always use bundled, and put the unbundled tests in their own job. I also updated the README |
anonrig
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the ability to skip compiling the bundled C++ ada sources and instead link against an externally provided ada library. This is useful when ada is already provided by the host build system (e.g. Bazel, CMake, or a distro package), where compiling the bundled copy would otherwise produce a second, duplicate copy of ada in the final binary.
Changes
Notes
ada-url = { version = "3", default-features = false, features = ["std"] }