Skip to content

add port back to host arguments (sends correct host-header, fixes redirects) #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bablokb wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add port back to host arguments (sends correct host-header, fixes redirects) #218

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f62a0d
add port back to host arguments (sends correct host-header, fixes red…
bablokb Jul 2, 2026
5bf248c
fix formatting
bablokb Jul 2, 2026
46b1afb
fix code to make tests happy
bablokb Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions adafruit_requests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,8 +620,10 @@ def request( # noqa: PLR0912,PLR0913,PLR0915 Too many branches,Too many argumen
raise ValueError("Unsupported protocol: " + proto)

if ":" in host:
host, port = host.split(":", 1)
host_only, port = host.split(":", 1)
port = int(port)
else:
host_only = host

if self._last_response:
self._last_response.close()
Expand All @@ -638,7 +640,7 @@ def request( # noqa: PLR0912,PLR0913,PLR0915 Too many branches,Too many argumen
while retry_count < 2:
retry_count += 1
socket = self._connection_manager.get_socket(
host,
host_only,
port,
proto,
session_id=self._session_id,
Expand Down
Loading