TinyUSB re-pin fixes ESP32-S2 and S3 REPL race - #11433
Merged
Merged
Conversation
nRF52840 and nRF52833. Newer TinyUSB also calls nrf52_errata_199, which the pinned nrfx does not name. Map it to the MDK errata_199 like the other three, so the nordic port builds across the TinyUSB bump. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
ESP32-S2 and S3. Moves the pin from 5453ed09f1 to 147ccf5e9, the merge of hathach/tinyusb#3937, which stops pasted REPL input being corrupted. 441 commits: hathach/tinyusb@5453ed0...147ccf5 Drop CFG_TUH_VENDOR: upstream removed the vendor host class and the option with it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
mikeysklar
marked this pull request as ready for review
September 21, 2026 16:03
tannewt
approved these changes
Sep 21, 2026
tannewt
left a comment
Member
There was a problem hiding this comment.
Code changes looks fine. I poked the CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the CircuitPython TinyUSB pin to current master (441 commits).
Adds one line so nRF52 boards still build.
Why
Pasting more than a few lines into the ESP32-S2 or S3 REPL drops and scrambles characters. TinyUSB fixed it upstream. Might as well re-pin to get the fix.
CircuitPython changes
Two lines in
supervisor/shared/usb/tusb_config.h. Every TinyUSB source file and option CircuitPython uses still exists.+#define nrf52_errata_199 errata_199dcd_nrf5x.ccalls it; nordic fails withimplicit declarationwithout it. Same mapping as the three already there. First commit, so every commit builds.-#define CFG_TUH_VENDOR 0Flash cost
All nine boards build clean on both sides with GCC 15.2.1, no new warnings. Bytes free,
en_US:9701f33a8f1e55bbdcffmetro_m0_expressmetro_m4_airlift_litefeather_nrf52840_expressfeather_stm32f405_expressadafruit_metro_rp2040adafruit_metro_rp2350raspberry_pi_pico2_wadafruit_metro_esp32s2adafruit_metro_esp32s3Hardware tested
All eight farm boards on
10.4.0-alpha.2-26-g1e55bbdcff, Ubuntu 24.04 host.How I tested it
Metro ESP32-S3. 40 test files, 50 times each, through the raw REPL:
The 64 KB test, sent over the REPL:
AI assistance
Claude Code was used. It made the change and ran the builds and farm. I checked the results.