feat(drift): add from_cli constructor and add docs#360
Open
tachyonicClock wants to merge 2 commits into
Open
Conversation
41ba69a to
9cdd0e0
Compare
…sting code to use them
9cdd0e0 to
1011461
Compare
Collaborator
Author
|
@vcerqueira does the first commit break anything for you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detector(CLI=...)this is now written asDetector.from_cli(...). The main constructor is just for argumentsDetector(delta=0.1). This gives users one way to do each thing rather than one way to do two things. I can imagine someone overriding their parameters withCLI=or being confused when it used MOA defaults instead of CapyMOA defaults. I also simplified some constructor logic. I'm considering using a similar pattern for classifiers as well, if we like it.