Skip to content

feat(drift): add from_cli constructor and add docs#360

Open
tachyonicClock wants to merge 2 commits into
adaptive-machine-learning:mainfrom
tachyonicClock:detector_docs
Open

feat(drift): add from_cli constructor and add docs#360
tachyonicClock wants to merge 2 commits into
adaptive-machine-learning:mainfrom
tachyonicClock:detector_docs

Conversation

@tachyonicClock
Copy link
Copy Markdown
Collaborator

@tachyonicClock tachyonicClock commented May 29, 2026

  • Add doc strings to drift detector creation. This was done using an LLM. I did ground the documentation using the MOA source code so I reckon it should be okay.
  • Rather than using Detector(CLI=...) this is now written as Detector.from_cli(...). The main constructor is just for arguments Detector(delta=0.1). This gives users one way to do each thing rather than one way to do two things. I can imagine someone overriding their parameters with CLI= or being confused when it used MOA defaults instead of CapyMOA defaults. I also simplified some constructor logic. I'm considering using a similar pattern for classifiers as well, if we like it.

@tachyonicClock tachyonicClock force-pushed the detector_docs branch 2 times, most recently from 41ba69a to 9cdd0e0 Compare May 29, 2026 03:27
@tachyonicClock
Copy link
Copy Markdown
Collaborator Author

@vcerqueira does the first commit break anything for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant