Skip to content

Use commandargs #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adiom-mark merged 1 commit into from
Apr 16, 2026
+4,437 −970
Merged

Use commandargs #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Run Gosec Security Scanner
uses: securego/gosec@master
with:
args: -exclude=G115 ./...
args: -exclude=G115 --exclude-generated ./...

- name: Build
run: go build -v ./...
Expand Down
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
go.work

# Binary
dsync
/dsync
java/target

# Log files
Expand Down
10 changes: 10 additions & 0 deletions buf.gen.commands.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
version: v2
plugins:
- local: protoc-gen-go
out: gen
opt: paths=source_relative
- local: protoc-gen-commandargs-urfave
out: gen
opt: paths=source_relative
Comment thread
coderabbitai[bot] marked this conversation as resolved.
inputs:
- directory: proto/connectorcommands
2 changes: 2 additions & 0 deletions buf.gen.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,5 @@ plugins:
out: java/src/main/java
- remote: buf.build/protocolbuffers/java:v29.1
out: java/src/main/java
inputs:
- directory: proto/dsync
Comment on lines +17 to +18

@coderabbitai coderabbitai Bot Apr 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Broken Buf generation input path (blocker).

Line 18 points to proto/dsync, which is missing in the repo context. That will make Buf generation fail immediately.
Please either create proto/dsync or update this input to the actual existing proto root.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@buf.gen.yaml` around lines 17 - 18, The buf.gen.yaml references a
non-existent proto input path under the inputs block ("directory: proto/dsync"),
which breaks Buf generation; fix it by either creating the missing proto/dsync
directory with the expected .proto files or updating the inputs.directory value
to the actual proto root in the repo (e.g., replace "proto/dsync" with the
correct path) so the inputs block in buf.gen.yaml points to an existing proto
directory.

6 changes: 6 additions & 0 deletions buf.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Generated by buf. DO NOT EDIT.
version: v2
deps:
- name: buf.build/adiom/commandargs
commit: 57609d4ad63a41cd86c89f5874199290
digest: b5:72c714f13e7013a860cfd0dff8c720c0d7584ccb9446514e052166067c2bfdc47227d38b33a4b64daaacb2acbd5c5acbdc8509d9dbd563a5e6c3814f4e87dcc6
6 changes: 5 additions & 1 deletion buf.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
# For details on buf.yaml configuration, visit https://buf.build/docs/configuration/v2/buf-yaml
version: v2
modules:
- path: proto
- path: proto/dsync
- path: proto/connectorcommands
name: buf.build/adiom/connectorcommands
deps:
- buf.build/adiom/commandargs
lint:
use:
- STANDARD
Expand Down
180 changes: 180 additions & 0 deletions gen/adiom/commands/connectors/v1/cosmos.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

104 changes: 104 additions & 0 deletions gen/adiom/commands/connectors/v1/cosmos_commandargs.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading