fix: resolve cipher-base to >=1.0.5 in 10 admin-ui-sdk packages (CVE-2025-9287) - #79
Open
anupamme wants to merge 1 commit into
Open
fix: resolve cipher-base to >=1.0.5 in 10 admin-ui-sdk packages (CVE-2025-9287)#79anupamme wants to merge 1 commit into
anupamme wants to merge 1 commit into
Conversation
…2025-9287) cipher-base <=1.0.4 is affected by CVE-2025-9287 (CVSS 9.1 Critical). All 10 older admin-ui-sdk sub-packages locked to 1.0.4 via the crypto-browserify -> browserify-aes/des/create-hash/create-hmac chain. Adds an npm `overrides` entry in each affected package.json to force cipher-base to >=1.0.5, then regenerates the lockfiles. The two menu/ packages already resolved 1.0.7 and are unchanged. Closes / supersedes adobe#76. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CVE-2025-9287 (CVSS 9.1 Critical) affects
cipher-baseversions ≤1.0.4. The dependency tree in 10 of the 12admin-ui-sdksub-packages resolvescipher-baseat 1.0.4 viacrypto-browserify→browserify-aes/browserify-des/create-hash/create-hmac.This PR adds an npm
overridesentry to each affectedpackage.jsonand regenerates the correspondingpackage-lock.jsonso thatcipher-baseresolves to ≥1.0.5 (lockfiles now pin 1.0.7).The two
menu/sub-packages (custom-menu,custom-menu-no-react) already resolvecipher-base@1.0.7and are unchanged.Affected packages (all under
admin-ui-sdk/):banner-notification/custom-mass-actionsbanner-notification/custom-order-view-buttoncustomer/custom-grid-columnscustomer/custom-mass-actionorder/custom-feesorder/custom-grid-columnsorder/custom-mass-actionorder/custom-view-buttonproduct/custom-grid-columnsproduct/custom-mass-actionNotes
cipher-baseis not a direct dependency of any package in this repo — it is fully transitive. This PR does not add it as a direct dependency;overridesis the correct npm mechanism for forcing a transitive version.overridesapproach pins onlycipher-baseand does not alter any other resolved dependency version.cipher-baseas a direct dependency.Test plan
npm install && npm ls cipher-base— confirm no1.0.4in the outputgrep -r '"version": "1.0.4"' admin-ui-sdk/*/package-lock.json— should return no matches forcipher-basenpm testin each sub-package (all usejest --passWithNoTests)🤖 Generated with Claude Code