Fix custom accept error message not shown for unsupported file type in file input - #1928
Open
farhaharoon0931-eng wants to merge 1 commit into
Conversation
…n file input The file-input widget's invalidMessage() looked up constraintMessages.invalidMimeType for the unsupported-file-type alert, but invalidMimeType is not an authorable constraint message key - the schema only exposes constraintMessages.accept (backed by the acceptMessage dialog property). As a result the custom message authors configure for file type validation was always ignored in favor of the generic fallback string, while the analogous maxFileSize custom message worked correctly since its key matched. Updated both the webpack source (ui.frontend) and the apps clientlib copy (ui.af.apps) to read constraintMessages.accept, and added a Cypress assertion mirroring the existing maxFileSize custom-message test.
mayankjindalmj
pushed a commit
that referenced
this pull request
Jul 31, 2026
…ported file type The File Attachment (fileinput) widget's invalidMessage() looked up the custom unsupported-file-type message under constraintMessages.invalidMimeType, which is not a real constraint key. The authorable key is `accept` (ConstraintType.ACCEPT), backed by the acceptMessage dialog property, so the custom message was always undefined and a generic fallback was shown. The maxFileSize custom message worked because it already uses the correct key. Fix: read constraintMessages.accept for the MIMETYPE case, in both the ui.frontend source (FormFileInputWidgetBase.js) and the v4 clientlib copy (fileinputwidget.js). Backport of master PR #1928 to release/650. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jul 31, 2026
mayankjindalmj
pushed a commit
that referenced
this pull request
Jul 31, 2026
…ed file type Adds the extra Cypress coverage from #1928, adapted to release/650: upload an unsupported-type file (sample.svg) to fileinput3 (accept=[application/pdf], now with an acceptMessage) and assert the alert equals constraintMessages.accept. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
4 tasks
mayankjindalmj
added a commit
that referenced
this pull request
Aug 4, 2026
…ile Attachment (#1940) * FORMS-26813 : backport PR #1928 - show custom acceptMessage for unsupported file type The File Attachment (fileinput) widget's invalidMessage() looked up the custom unsupported-file-type message under constraintMessages.invalidMimeType, which is not a real constraint key. The authorable key is `accept` (ConstraintType.ACCEPT), backed by the acceptMessage dialog property, so the custom message was always undefined and a generic fallback was shown. The maxFileSize custom message worked because it already uses the correct key. Fix: read constraintMessages.accept for the MIMETYPE case, in both the ui.frontend source (FormFileInputWidgetBase.js) and the v4 clientlib copy (fileinputwidget.js). Backport of master PR #1928 to release/650. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * FORMS-26813 : add test scenario for custom acceptMessage on unsupported file type Adds the extra Cypress coverage from #1928, adapted to release/650: upload an unsupported-type file (sample.svg) to fileinput3 (accept=[application/pdf], now with an acceptMessage) and assert the alert equals constraintMessages.accept. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Mayank Jindal <mayankjindal@adobe.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
invalidMessage()looked upconstraintMessages.invalidMimeTypefor the "unsupported file type" alert, butinvalidMimeTypeis not an authorable constraint message key — the schema only exposesconstraintMessages.accept(backed by theacceptMessagedialog property, seeAbstractBaseImpl.ConstraintMessages#getAcceptConstraintMessage).maxFileSizecustom message worked correctly since its key matched (constraintMessages.maxFileSize).ui.frontend/src/view/FormFileInputWidgetBase.js) and the apps clientlib copy (ui.af.apps/.../fileinput/v4/fileinput/clientlibs/site/js/fileinputwidget.js).Root cause (reproduced live)
maxFileSizemessage ✅acceptMessage)accept/acceptMessagetext ✅Test plan
node --checkon both modified JS filesshould display a custom error message configured by the user for unsupported file typeinfileinputv4.runtime.cy.js, mirroring the existingmaxFileSizecustom-message testacceptMessageto thefileinput7fixture field in the IT sample content used by that spec