Skip to content

Forms runtime metadata enricher af core - #1932

Open
barshat7 wants to merge 3 commits into
devfrom
forms-runtime-metadata-enricher-af-core
Open

Forms runtime metadata enricher af core#1932
barshat7 wants to merge 3 commits into
devfrom
forms-runtime-metadata-enricher-af-core

Conversation

@barshat7

@barshat7 barshat7 commented Jul 24, 2026

Copy link
Copy Markdown

Description

This is the same PR as #1844

The enricher was implemented against the OpenAPI-generated dataplane
types (openapimodels.pages.*), but the merged dataplane SPI contract
exposes only owned types (ComponentDefinition/Field/Option) to avoid
an ABI break on every schema regen. Update the enricher and its test
to the owned types, pin sites-dataplane to the version that ships
them, and fix two latent test bugs (wrong AemContext factory, nested
Mockito stubbing) that -DskipTests had been hiding.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Example content definition:

{
          "name": "./prefillService",
          "label": "Prefill service",
          "component": "select",
          "valueType": "string",
          "required": false,
          "description": "Select a prefill service to fetch form data when the form renders.",
          "multi": false,
          "options": [
            {
              "name": "None",
              "value": ""
            },
            {
              "name": "Core Custom Pre-fill Service",
              "value": "Core Custom Pre-fill Service"
            },
            {
              "name": "Forms Portal Draft Prefill Service",
              "value": "FP"
            },
            {
              "name": "Repeatable AF Pre-fill Service",
              "value": "Repeatable AF Pre-fill Service"
            },
            {
              "name": "Form Data Model Prefill service",
              "value": "FDM"
            }
          ]
        }
{
          "name": "./actionType",
          "label": "Submit action",
          "component": "select",
          "valueType": "string",
          "required": false,
          "multi": false,
          "options": [
            {
              "name": "Store content",
              "value": "fd/af/components/guidesubmittype/store"
            },
            {
              "name": "Send email",
              "value": "fd/af/components/guidesubmittype/email"
            },
            {
              "name": "Invoke a Power Automate flow",
              "value": "fd/powerautomate/components/actions/pasubmit"
            },
            {
              "name": "Submit using Form Data Model",
              "value": "fd/afaddon/components/actions/fdm"
            },
            {
              "name": "Submit to REST endpoint",
              "value": "fd/af/components/guidesubmittype/restendpoint"
            },
            {
              "name": "Core Custom AF Submit",
              "value": "forms-core-components-it/customsubmission/logsubmit"
            },
            {
              "name": "Submit to Marketo Engage",
              "value": "fd/afaddon/components/actions/marketo"
            },
            {
              "name": "Submit to OneDrive",
              "value": "fd/afaddon/components/actions/onedrivestorage"
            },
            {
              "name": "Submit to SharePoint",
              "value": "fd/afaddon/components/actions/sharepointstorage"
            },
            {
              "name": "Invoke a Workfront Fusion scenario",
              "value": "fd/workfrontfusion/components/actions/wfsubmit"
            },
            {
              "name": "Store PDF",
              "value": "fd/afaddon/components/actions/storepdf"
            },
            {
              "name": "Submit to Azure Blob Storage",
              "value": "fd/afaddon/components/actions/azureblobstorage"
            },
            {
              "name": "Invoke an AEM workflow",
              "value": "fd/dashboard/components/actions/aemworkflowsubmit"
            }
          ]
        }

@rismehta

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@github-actions
github-actions Bot force-pushed the forms-runtime-metadata-enricher-af-core branch from d93dba6 to aa24238 Compare July 24, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants