Skip to content

FORMS-24185: add regression test for fragment without a panel - #1937

Open
AnurudraS wants to merge 1 commit into
devfrom
FORMS-24185
Open

FORMS-24185: add regression test for fragment without a panel#1937
AnurudraS wants to merge 1 commit into
devfrom
FORMS-24185

Conversation

@AnurudraS

Copy link
Copy Markdown
Contributor

PR #1603 (reverted, see FORMS-24163) assumed every fragment's label container used the generic panel class, which threw when a fragment's fragmentPath resolved directly to fields with no wrapping panel. The existing fixture (test-fragment) always wraps fields in a panel, so this shape went uncaught. Reuses the existing container-rules.html page, which already embeds a panel-less fragment.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

PR #1603 (reverted, see FORMS-24163) assumed every fragment's label
container used the generic panel class, which threw when a fragment's
fragmentPath resolved directly to fields with no wrapping panel. The
existing fixture (test-fragment) always wraps fields in a panel, so
this shape went uncaught. Reuses the existing container-rules.html
page, which already embeds a panel-less fragment.
@adobe-bot

Copy link
Copy Markdown

Accessibility Violations Found

Id Impact
aria-required-attr critical
empty-heading minor
label-title-only serious
page-has-heading-one moderate
target-size serious

@adobe-bot

Copy link
Copy Markdown

Accessibility Violations Found

Id Impact
aria-required-attr critical
empty-heading minor
label-title-only serious
target-size serious

@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants