Skip to content

feat(table) : Column Width enhancement matching the authoring and runtime preview #1949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
armaang1729 wants to merge 1 commit into
base: dev
Choose a base branch
from
+20 −43
Open

feat(table) : Column Width enhancement matching the authoring and runtime preview #1949

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 20 additions & 43 deletions ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/table/v1/table/table.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,50 +37,27 @@
<div data-sly-call="${shortDescription.shortDescription @componentId=table.id, shortDescriptionVisible=table.tooltipVisible, shortDescription=table.tooltip, bemBlock='cmp-adaptiveform-table'}" data-sly-unwrap></div>
<div data-sly-call="${longDescription.longDescription @componentId=table.id, longDescription=table.description, bemBlock='cmp-adaptiveform-table'}" data-sly-unwrap></div>

<!--/* EDIT MODE: column widths not applied; children render their own <tr> with data-cq-data-path for the overlay. */-->
<sly data-sly-test="${wcmmode.edit}">
<table class="cmp-adaptiveform-table__widget"
aria-label="${table.label.value @ context='attribute'}">
<thead class="cmp-adaptiveform-table__head">
<sly data-sly-list.child="${resource.listChildren}">
<sly data-sly-test="${child.resourceType == 'core/fd/components/form/tableheader/v1/tableheader'}">
<sly data-sly-resource="${child @ decoration=false}"></sly>
</sly>
<table class="cmp-adaptiveform-table__widget"
aria-label="${table.label.value @ context='attribute'}"
data-sly-attribute.style="${properties.columnWidth ? 'table-layout: fixed; width: 100%' : false}">
<sly data-sly-test="${table.columnWidthsConfigured}">
<colgroup data-sly-list.colStyle="${table.columnWidthColStyles}">
<col style="${colStyle @ context='styleString'}" />
</colgroup>
</sly>
<thead class="cmp-adaptiveform-table__head">
<sly data-sly-list.child="${resource.listChildren}">
<sly data-sly-test="${child.resourceType == 'core/fd/components/form/tableheader/v1/tableheader'}">
<sly data-sly-resource="${child @ decoration=false}"></sly>
</sly>
</thead>
<tbody class="cmp-adaptiveform-table__body">
<sly data-sly-list.child="${resource.listChildren}">
<sly data-sly-test="${child.resourceType == 'core/fd/components/form/tablerow/v1/tablerow'}">
<sly data-sly-resource="${child @ decoration=false}"></sly>
</sly>
</sly>
</tbody>
</table>
</sly>
<!--/* PUBLISH MODE: column widths applied via colgroup; proper semantic table for accessibility. */-->
<sly data-sly-test="${!wcmmode.edit}">
<table class="cmp-adaptiveform-table__widget"
aria-label="${table.label.value @ context='attribute'}"
data-sly-attribute.style="${properties.columnWidth ? 'table-layout: fixed; width: 100%' : false}">
<sly data-sly-test="${table.columnWidthsConfigured}">
<colgroup data-sly-list.colStyle="${table.columnWidthColStyles}">
<col style="${colStyle @ context='styleString'}" />
</colgroup>
</sly>
<thead class="cmp-adaptiveform-table__head">
<sly data-sly-list.child="${resource.listChildren}">
<sly data-sly-test="${child.resourceType == 'core/fd/components/form/tableheader/v1/tableheader'}">
<sly data-sly-resource="${child @ decoration=false}"></sly>
</sly>
</sly>
</thead>
<tbody class="cmp-adaptiveform-table__body">
<sly data-sly-list.child="${resource.listChildren}">
<sly data-sly-test="${child.resourceType == 'core/fd/components/form/tablerow/v1/tablerow'}">
<sly data-sly-resource="${child @ decoration=false}"></sly>
</sly>
</thead>
<tbody class="cmp-adaptiveform-table__body">
<sly data-sly-list.child="${resource.listChildren}">
<sly data-sly-test="${child.resourceType == 'core/fd/components/form/tablerow/v1/tablerow'}">
<sly data-sly-resource="${child @ decoration=false}"></sly>
</sly>
</tbody>
</table>
</sly>
</sly>
</tbody>
</table>
</div>
Loading