[FORMS-27260] Updating datepicker version and adding to product - #1952
Closed
muskgupta wants to merge 3 commits into
Closed
[FORMS-27260] Updating datepicker version and adding to product#1952muskgupta wants to merge 3 commits into
muskgupta wants to merge 3 commits into
Conversation
github-actions
Bot
force-pushed
the
DatepickerV2
branch
from
August 11, 2026 10:27
f376d98 to
035d4d2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Accessibility Violations Found
|
Accessibility Violations Found
|
| <replace file="target/jcr_root/libs/core/fd/components/form/container/v2/container/.content.xml" token=".core-wcm" value="Core Content" /> | ||
| <replace file="target/jcr_root/libs/core/fd/components/form/textinput/v1/textinput/.content.xml" token=".core-adaptiveform" value="Core Adaptive Form" /> | ||
| <replace file="target/jcr_root/libs/core/fd/components/form/datepicker/v1/datepicker/.content.xml" token=".core-adaptiveform" value="Core Adaptive Form" /> | ||
| <replace file="target/jcr_root/libs/core/fd/components/form/datepicker/v1/datepicker/.content.xml" token=".core-adaptiveform" value=".core-adaptiveform" /> |
Contributor
There was a problem hiding this comment.
it doesn't require a replace, also this needs to be done with all latest versions
Member
Author
There was a problem hiding this comment.
Removed for datepicker, also updated all components in the next commit.
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
Member
Author
|
closing this PR - datepicker v2 is not needed since no DOM changes are there. will raise a separate PR to remove datepicker v2 and move all a11y fixes added in v2 to v1 itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: