Skip to content

fix: add jcr:primaryType to table child node in tablerow and tableheader - #1958

Merged
armaang1729 merged 2 commits into
devfrom
dev-fix
Aug 13, 2026
Merged

fix: add jcr:primaryType to table child node in tablerow and tableheader#1958
armaang1729 merged 2 commits into
devfrom
dev-fix

Conversation

@armaang1729

@armaang1729 armaang1729 commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Filevault rejects empty nodes without jcr:primaryType when filter mode=replace.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@adobe-bot

adobe-bot commented Aug 13, 2026

Copy link
Copy Markdown

Accessibility Violations Found

Id Impact
aria-required-attr critical
empty-heading minor
label-title-only serious
target-size serious

@adobe-bot

adobe-bot commented Aug 13, 2026

Copy link
Copy Markdown

Accessibility Violations Found

Id Impact
aria-required-attr critical
empty-heading minor
label-title-only serious
page-has-heading-one moderate
target-size serious

@adobe-bot

adobe-bot commented Aug 13, 2026

Copy link
Copy Markdown

Accessibility Violations Found

Id Impact
aria-required-attr critical
empty-heading minor
label-title-only serious
target-size serious

1 similar comment
@adobe-bot

adobe-bot commented Aug 13, 2026

Copy link
Copy Markdown

Accessibility Violations Found

Id Impact
aria-required-attr critical
empty-heading minor
label-title-only serious
target-size serious

@adobe-bot

adobe-bot commented Aug 13, 2026

Copy link
Copy Markdown

Accessibility Violations Found

Id Impact
aria-required-attr critical
empty-heading minor
label-title-only serious
page-has-heading-one moderate
target-size serious

@adobe-bot

adobe-bot commented Aug 13, 2026

Copy link
Copy Markdown

Accessibility Violations Found

Id Impact
aria-required-attr critical
empty-heading minor
label-title-only serious
target-size serious

@armaang1729
armaang1729 merged commit 02ea7fe into dev Aug 13, 2026
9 checks passed
@armaang1729
armaang1729 deleted the dev-fix branch August 13, 2026 09:08
armaang1729 added a commit that referenced this pull request Aug 13, 2026
@armaang1729 Armaan Gupta Armaan Gupta
fix: add jcr:primaryType to table child node in tablerow and tablehea…
6f8e160 
…der (#1958)

* fixing the Filevault issue

* added jcr:primaryType=nt:unstructured to the child Nodes

---------

Co-authored-by: Armaan Gupta <armaang@Armaans-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sakshi-arora1 sakshi-arora1 sakshi-arora1 approved these changes
@muskgupta muskgupta muskgupta approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@armaang1729 @adobe-bot @sakshi-arora1 @muskgupta