Repository navigation
fix: bump archiver ^7 -> ^8 to drop deprecated glob@10 - #940
Merged
AnujVishwakarma-src merged 1 commit intoSep 28, 2026
Merged
Conversation
archiver@7 pulled archiver-utils@5 -> glob@^10 (deprecated), a remaining
npm warn deprecated on npm install -g @adobe/aio-cli. archiver@8 drops
archiver-utils and glob entirely.
archiver@8 is ESM-only with a class API: zipHelper() now loads it via
dynamic import() and uses new ZipArchive({ zlib }) instead of
archiver('zip', ...). Instance API (pipe/directory/file/on/destroy/finalize)
unchanged; the sole caller already awaits zipHelper(). Test uses
jest.unstable_mockModule for the ESM class mock.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
glob@10.5.0is a remainingnpm warn deprecatedline onnpm install -g @adobe/aio-cli. It enters viaarchiver@7 → archiver-utils@5.0.2 → glob@^10(archiver-utils latest hard-pinsglob ^10; glob is non-deprecated only at 13+). A root npm override does not reach end users. The fix is a real dependency change that propagates — upgrading archiver. This is the plugin-app half; the aio-lib-runtime half shipped in aio-lib-runtime 7.5.0 (APPBLD-5201).Change
Bump
archiver ^7 → ^8. archiver@8 dropsarchiver-utilsandglobentirely (usesreaddir-glob/tar-stream/zip-stream).archiver@8 is ESM-only with a class API.
zipHelper():const { ZipArchive } = await import('archiver')(this command stays CommonJS),new ZipArchive({ zlib: { level: 9 } })instead ofarchiver('zip', { ... }).Instance API (
pipe/directory/file/on/destroy/finalize) unchanged; the sole caller (pack.js:112) alreadyawaitszipHelper(). Test converted tojest.unstable_mockModule(class shape) and made async-aware.Validation
aio app pack→zipHelper()(archiver@8) produced a validapp.zip(74 files, ~1MB, verified viaunzip -l);aio app build+aio app deploy(withaio-lib-runtime@7.5.0→ archiver@8) → Successful deployment to live Stage.ERR_REQUIRE_ESM/ constructor errors.Depends on APPBLD-5201 (aio-lib-runtime 7.5.0, released).
New-app E2E (2026-09-28)
Also validated on a freshly-created app (
aio app init):aio app buildproduced valid action zips via the runtimezip()(archiver@8), andaio app packproduced a validapp.zip(35 files) viazipHelper()(archiver@8). Both the plugin-appzipHelperand the runtimezippaths are now confirmed on both a new and an existing app.