Skip to content

feat: ACNA-4515 add pr-reviewer workflow#38

Merged
chsrimanaswi merged 1 commit intomasterfrom
ACNA-4515-Add-pr-reviewer-workflow
Apr 28, 2026
Merged

feat: ACNA-4515 add pr-reviewer workflow#38
chsrimanaswi merged 1 commit intomasterfrom
ACNA-4515-Add-pr-reviewer-workflow

Conversation

@chsrimanaswi
Copy link
Copy Markdown
Contributor

Description

Adds an AI-powered PR reviewer workflow that automatically reviews pull requests using Claude via AWS Bedrock. Triggers on PR open/reopen/synchronize and on /review or /pr-reviewer comments by admins or maintainers.

Related Issue

ACNA-4515

Motivation and Context

Reduces code review toil by providing automated first-pass reviews with inline suggestions. Part of a broader rollout across App Builder repos.

How Has This Been Tested?

Tested end-to-end in adobe/generator-aio-app — workflow triggers correctly on PR events and /review comments, posts inline suggestions and summary reviews via github-actions[bot].

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 PR Reviewer

The workflow is well-structured with clear separation between gate-checking and the actual review job. The permission model and comment-triggering logic are sound, but there are a few security and reliability concerns worth addressing.

📝 4 suggestion(s) - Please review inline comments below.


💡 How to re-trigger

Comment /review or /pr-reviewer on this PR

Comment thread .github/workflows/pr-review.yml
# Intentionally require admin or maintain; write collaborators are excluded to
# limit who can trigger potentially expensive/sensitive review automation.
if [ "$PERM" = "admin" ] || [ "$PERM" = "maintain" ]; then
DATA=$(gh api repos/$GITHUB_REPOSITORY/pulls/$ISSUE_NUMBER)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ISSUE_NUMBER comes from an environment variable sourced from github.event.issue.number. While GitHub typically provides an integer here, it's safer to validate or quote it explicitly to avoid path traversal or injection in the API call.

Suggested change
DATA=$(gh api repos/$GITHUB_REPOSITORY/pulls/$ISSUE_NUMBER)
DATA=$(gh api "repos/$GITHUB_REPOSITORY/pulls/$ISSUE_NUMBER")

Comment thread .github/workflows/pr-review.yml
Comment thread .github/workflows/pr-review.yml
@chsrimanaswi chsrimanaswi dismissed github-actions[bot]’s stale review April 27, 2026 22:52

Proposed changes not required

Copy link
Copy Markdown
Member

@shazron shazron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the required checks in Settings -> Branches. Remove the node 18 checks, add the 22, 24 checks.

@chsrimanaswi chsrimanaswi merged commit f2081ff into master Apr 28, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants