Conversation
…nvas editor Aligns canvas editor (ew-editor-doc/prose.js) with the existing pattern in edit/prose/index.js so the Bearer token never appears in the URL or server logs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
Commits
|
mhaack
approved these changes
Jun 16, 2026
| return; | ||
| } | ||
| wsProvider.params = { Authorization: `Bearer ${fresh}` }; | ||
| wsProvider.protocols = ['yjs', fresh]; |
Member
There was a problem hiding this comment.
'yjs' is hardcoded in three spots: init, the non-expired refresh path, and the expired refresh path. we could extract a const BASE_PROTOCOLS = ['yjs'] and use [...BASE_PROTOCOLS, token] so they can't drift. tiny thing but worth not having to hunt them all down later.
Contributor
Author
There was a problem hiding this comment.
while I agree with the theory, replacing 5 characters with 17 and making this less readable does not necessarily help here :)
And Claude is good at search and replace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ew-editor-doc/prose.js) was sending the Bearer token as anAuthorizationURL query parameter on WebSocket connections, causing it to appear verbatim in server/CDN logsedit/prose/index.jsalready used the correct approach: passing the token as a WebSocket sub-protocol value (insec-websocket-protocolheaders), which da-collab already supportsTest plan
Test page: https://wsproto--da-live--adobe.aem.live/
Authorization=Bearer%20...appears in da-collab request logs after deployprotocolsassignment🤖 Generated with Claude Code