Conversation
At the org level (path depth 1), clicking New skips the type menu and goes straight to folder-name input. At site level and deeper the full menu (Document, Sheet, Media, Link, Folder) is preserved. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
When daFetch returns a non-ok response or throws (e.g. on Windows where drag-and-drop from File Explorer can conflict with the upload), the FPO placeholder is now removed from the document and a dismissing toast is shown to the author. Previously the placeholder stayed stuck forever. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
Validating with customer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
daFetchthrows or returns a non-ok response during image drag-and-drop upload, the FPO placeholder (fpo.svg) is now removed from the document instead of being left stuck permanentlyfpo.svgeitherRoot cause
On Windows, dragging an image from File Explorer into the editor can cause the upload
PUTrequest to fail (browser navigation to afile:///URI competing with the upload, or corporate proxy blocking requests to the.grspath). The original code had no error recovery — any failure silently left the FPO placeholder in the document, and since it was already synced to the Yjs collab layer, it persisted across reloads.Test plan
Test page: https://imgdrop--da-live--adobe.aem.page
npm test)🤖 Generated with Claude Code