refactor: source ewFlags from nx2#1041
Open
kozmaadrian wants to merge 2 commits into
Open
Conversation
10 tasks
kozmaadrian
commented
Jun 24, 2026
| } | ||
|
|
||
| export async function readConfiguredToolPanelView({ org, site }) { | ||
| export async function readConfiguredToolPanelView({ org, site }, getEWFlags = loadEWFlags) { |
Contributor
Author
There was a problem hiding this comment.
I've used dependency injection so panel.js/view.js stay unit-testable without standing up the nx2 runtime, tests pass a fake flags loader while production defaults to the real nx2 one. This avoids keeping a copy of the flag fetching logic in a fixture, which didn't feel right for me, since it duplicates code that already lives (and is tested) in nx2 and would drift over time.
| import { getFirstSheet, fetchDaConfigs } from '../../shared/utils.js'; | ||
| import { isEWEnabled } from '../../shared/ewFlags.js'; | ||
| import { getNx, sanitizePathParts } from '../../../scripts/utils.js'; | ||
| import { getNx, sanitizePathParts, getNx2EwFlags } from '../../../scripts/utils.js'; |
Contributor
There was a problem hiding this comment.
I would just call it getNxEWFlags, skip the versioning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the local
blocks/shared/ewFlags.jsand sources EW flags from nx2 instead(adobe/da-nx#), via a new
getNx2EwFlags()loader inscripts/utils.js(mirrors
getNx2Api).Why
The flag logic is common to Nexter consumers, so it lives in nx2 now. Keeping a
duplicate copy here would drift.
Changes
scripts/utils.js: addgetNx2EwFlags().canvas/utils/panel.js,canvas/utils/view.js: take the flags loader as aninjected dependency (defaults to nx2), so the consumers stay unit-testable
without the nx2 runtime.
browse/da-browse,canvas/ew-canvas-header: loadisEWEnabled/isEwChatDisabledfrom nx2.blocks/shared/ewFlags.jsand its test.Notes
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: