fix: hlx6 browse details (last-modified-by + AEM status path)#1047
Open
chrischrischris wants to merge 2 commits into
Open
fix: hlx6 browse details (last-modified-by + AEM status path)#1047chrischrischris wants to merge 2 commits into
chrischrischris wants to merge 2 commits into
Conversation
hlx6 version records no longer carry last-modified info and use ULID-based entries instead of /versionsource urls, so the legacy parsing in updateDAStatus threw and left "Last Modified By" stuck on "Checking". For hlx6, read x-last-modified-by from a HEAD on the document (via source.getMetadata) and count the version records directly. The hlx5 path is unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
updateAEMStatus passed the full path (including .html) to status.get, but AEM resolves HTML pages by their extensionless path. Strip the .html extension for html items, matching the idiom already used in da-list.js. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two fixes to the browse view "additional details" panel (
da-list-item) for Helix 6 sites.1.
Last Modified Bynever resolves on hlx6 sitesupdateDAStatusparsed the legacy version-list shape (/versionsourceurls +usersarray). hlx6.versionsrecords are ULID-based and carry nousers, so the call threw and left Last Modified By stuck on "Checking".x-last-modified-byfrom aHEADon the document (viasource.getMetadata) and normalize it the same way as the legacy path./versionsourcefilter yielded0on hlx6).2. AEM status requested with
.htmlextensionupdateAEMStatuspassed the full path (including.html) tostatus.get, but AEM resolves HTML pages by their extensionless path. Strip.htmlfor html items, matching the idiom already used inda-list.js.Testing
anonymousfallback) and the extensionless AEM status path (html stripped, non-html untouched).da-list-itemsuite: 42 passed, 0 failed; eslint clean.🤖 Generated with Claude Code