-
Notifications
You must be signed in to change notification settings - Fork 63
fix: rewrite aem.page/aem.live image srcs in editor to prevent 401 errors #930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andreituicu
wants to merge
10
commits into
main
Choose a base branch
from
fximg
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
176d3be
fix: Images stored in media bus with auth enabled not rendering
andreituicu 6685bd9
fix: Images stored in media bus with auth enabled not rendering
andreituicu c22aa1e
fix: Images stored in media bus with auth enabled not rendering
andreituicu 836289a
fix: Images stored in media bus with auth enabled not rendering
andreituicu b08d1d9
fix: Images stored in media bus with auth enabled not rendering
andreituicu 5910474
fix: Images stored in media bus with auth enabled not rendering
andreituicu aee0536
fix: Images stored in media bus with auth enabled not rendering
andreituicu 7e714ac
fix: Images stored in media bus with auth enabled not rendering
andreituicu 91afe27
fix: Images stored in media bus with auth enabled not rendering
andreituicu dfe691e
fix: Images stored in media bus with auth enabled not rendering
andreituicu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| /** | ||
| * Rewrites an image src from an AEM preview/publish host to the DA preview host. | ||
| * | ||
| * Images stored in DA content may reference *.aem.page (preview) or *.aem.live | ||
| * (publish) URLs. These hosts require AEM authentication that the DA editor does | ||
| * not carry, causing 401 errors when the browser fetches them. The equivalent | ||
| * *.preview.da.live URL serves the same content and is accessible from the editor. | ||
| * | ||
| * @param {string} src - The original image src URL. | ||
| * @returns {string} The rewritten src, or the original if no rewrite was needed. | ||
| */ | ||
| export function rewriteImageSrcForEditor(src) { | ||
| try { | ||
| const url = new URL(src); | ||
| if (url.host.endsWith('.aem.page') || url.host.endsWith('.aem.live')) { | ||
| url.host = url.host.replace(/\.aem\.(page|live)$/, '.preview.da.live'); | ||
| return url.toString(); | ||
| } | ||
| } catch { | ||
| // relative or malformed src — leave unchanged | ||
| } | ||
| return src; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| import { expect } from '@esm-bundle/chai'; | ||
| import { rewriteImageSrcForEditor } from '../../../../../blocks/edit/prose/image-utils.js'; | ||
|
|
||
| describe('rewriteImageSrcForEditor', () => { | ||
| it('rewrites aem.page host to preview.da.live', () => { | ||
| expect(rewriteImageSrcForEditor('https://main--site--org.aem.page/img.jpg')) | ||
| .to.equal('https://main--site--org.preview.da.live/img.jpg'); | ||
| }); | ||
|
|
||
| it('rewrites aem.live host to preview.da.live', () => { | ||
| expect(rewriteImageSrcForEditor('https://main--site--org.aem.live/img.jpg')) | ||
| .to.equal('https://main--site--org.preview.da.live/img.jpg'); | ||
| }); | ||
|
|
||
| it('preserves the path and query string when rewriting', () => { | ||
| expect(rewriteImageSrcForEditor('https://main--site--org.aem.page/media_abc.jpg?width=2000&format=webply')) | ||
| .to.equal('https://main--site--org.preview.da.live/media_abc.jpg?width=2000&format=webply'); | ||
| }); | ||
|
|
||
| it('leaves unrelated URLs unchanged', () => { | ||
| expect(rewriteImageSrcForEditor('https://example.com/img.jpg')) | ||
| .to.equal('https://example.com/img.jpg'); | ||
| }); | ||
|
|
||
| it('leaves content.da.live URLs unchanged', () => { | ||
| expect(rewriteImageSrcForEditor('https://content.da.live/org/repo/img.jpg')) | ||
| .to.equal('https://content.da.live/org/repo/img.jpg'); | ||
| }); | ||
|
|
||
| it('leaves relative URLs unchanged', () => { | ||
| expect(rewriteImageSrcForEditor('/img/photo.jpg')).to.equal('/img/photo.jpg'); | ||
| }); | ||
|
|
||
| it('leaves malformed URLs unchanged', () => { | ||
| expect(rewriteImageSrcForEditor('not a url')).to.equal('not a url'); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.