fix(kraft): filter controller-only nodes from Cruise Control remove_broker - #307
Open
amuraru wants to merge 1 commit into
Open
fix(kraft): filter controller-only nodes from Cruise Control remove_broker#307amuraru wants to merge 1 commit into
amuraru wants to merge 1 commit into
Conversation
…roker The add_broker and rebalance branches of the Cruise Control task controller already drop controller-only nodes before calling Cruise Control (CC has no knowledge of them in KRaft mode), but the remove_broker branch did not. It relied entirely on the upstream invariant that controller-only nodes never receive a GracefulDownscaleRequired state. If that invariant ever regressed, a controller-only broker id would be sent to CC's remove_broker unfiltered and error out / stall the operation. Apply util.FilterControllerOnlyNodes in the remove_broker branch too, so all three broker-id CC operations are symmetrically guarded, and only issue the CC request when the filtered id list is non-empty. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> (cherry picked from commit f626ded)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #300 (3/6).
The
add_brokerandrebalancebranches of the Cruise Control taskcontroller already drop controller-only nodes before calling Cruise Control
(CC has no knowledge of them in KRaft mode), but the
remove_brokerbranchdid not. It relied entirely on the upstream invariant that controller-only
nodes never receive a
GracefulDownscaleRequiredstate. If that invariantever regressed, a controller-only broker id would be sent to CC's
remove_brokerunfiltered and error out / stall the operation.Applies
util.FilterControllerOnlyNodesin theremove_brokerbranch too,so all three broker-id CC operations are symmetrically guarded, and only
issues the CC request when the filtered id list is non-empty.