test(e2e): print a running [k/N] specs-done progress counter - #311
Open
amuraru wants to merge 1 commit into
Open
test(e2e): print a running [k/N] specs-done progress counter#311amuraru wants to merge 1 commit into
amuraru wants to merge 1 commit into
Conversation
The e2e suite runs --ginkgo.v but Ginkgo only prints the spec count
up front ("Will run N of N specs") and a final summary, so CI logs
give no indication of progress while the ~45m run is in flight.
Add a ReportBeforeSuite hook to capture the total spec count and a
ReportAfterEach hook that prints "[k/N specs done] <spec>: <state>
(took <duration>)" after every spec, so progress and per-spec timing
can be read straight off the CI log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The e2e suite runs
--ginkgo.v(make test-e2e), but Ginkgo only printsthe total spec count once up front ("Will run N of N specs") and a final
summary at the very end. During the ~45m CI run there's no way to tell how
far along a run is from the log — e.g. https://github.com/adobe/koperator/actions/runs/31584238727/job/94074210240?pr=304.
Adds a
ReportBeforeSuitehook to capture the total spec count and aReportAfterEachhook that prints:after every spec, so both progress and per-spec timing are visible straight
off the CI log as the run streams. The suite runs in series (no
-p), soplain package-level counters are safe without extra synchronization.
Verified with
--ginkgo.dry-run(99/99 specs, correct counter) plusgo build/go vet/golangci-lintontests/e2e.