[AEEE-35854][MWPW-199140] Firefly Logo on transition screen for express url#826
[AEEE-35854][MWPW-199140] Firefly Logo on transition screen for express url#826vipu0303 wants to merge 1 commit into
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
@vipu0303 Thanks for pushing out this fix. Harry was actually able to resolve this issue on the T&O side, so we no longer need this fix on our end. We can go ahead and close this PR. |
Hi @sanjayms01 As discussed, for now since we have put the firefly asset in the express path, the media file path is getting resolved and working. But that is actually a workaround. We should actually resolve the path of the media used in a fragment, relative to the fragment path and not relative to the path where this fragment is being used. |
Fix for correctly loading the media on the Transition screen.
What the old code did
The old code only ran replaceDotMedia for Acrobat, and resolved media paths using contentRoot from the current page's config.
Instead of using contentRoot, we construct the base URL from where the fragment is actually fetched and then resolve each ./media_* relative to that.
This is correct for every domain — Firefly, Acrobat, Express — because the media always lives next to the fragment, regardless of what contentRoot is or which page loads the fragment.
Resolves:
AEEE-35854
MWPW-199140
For Validation use below URL:
https://www.adobe.com/express/feature/image/remove-background?at_preview_token=lLr7bJrDlMCVKw90nSqAxA&at_preview_index=1_2&at_preview_listed_activities_only=true&at_preview_evaluate_as_true_audience_ids=2515310
and replace the transition-screen.js file with the new file content.
Test URLs: