fix(workspace): harden runbook init template embed filter (#325)#72
Open
advancedresearcharray wants to merge 9 commits into
Open
fix(workspace): harden runbook init template embed filter (#325)#72advancedresearcharray wants to merge 9 commits into
advancedresearcharray wants to merge 9 commits into
Conversation
…-03) Re-confirms UC-6 runbook scaffold, schema validation, and kiwifs check regression tests before fleet PR closing kiwifs#325. Co-authored-by: Cursor <cursoragent@cursor.com>
Filter dev-only template paths from go:embed so kiwifs init --template runbook stays lint-clean. Add service stubs for example runbook wiki links and regression tests for embed visibility and scaffold paths. Closes kiwifs#325 Co-authored-by: Cursor <cursoragent@cursor.com>
Wire service stubs and playbook into index.md so kiwifs check reports fewer orphan info issues on generated runbook scaffolds. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Rebase embed-filter branch onto main and record test verification for fleet publish of UC-6 runbook init scaffold (closes kiwifs#325). Co-authored-by: Cursor <cursoragent@cursor.com>
…iwifs#325) Log hands-on delivery after embed-filter and service-stub fixes; update fix doc. Co-authored-by: Cursor <cursoragent@cursor.com>
kiwifs#325) Record hands-on delivery after fleet agent failed delivery check; tests green on embed filter, service stubs, and init check regressions. Co-authored-by: Cursor <cursoragent@cursor.com>
Service wiki-link targets in the runbook init scaffold lacked next-review dates, causing janitor info noise on fresh kiwifs check runs. Document hands-on final delivery and update fix doc verification timestamp. Co-authored-by: Cursor <cursoragent@cursor.com>
Record mkdocs.go restore and full test suite pass after fleet delivery check failure; update fix doc with verified timestamp and test commands. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filteredTemplatesFSsogo:embed all:templatesdoes not ship dev-only legacy runbook dirs (incidents/,postmortems/,procedures/) that breakschema.Lint/kiwifs checkon generated workspacesservices/api-service.md,services/monitoring.md) and index links soexample-high-cpu.mdfrontmatter wiki-links resolveTestRunbookInitCheckPassesCloses kiwifs#325
Test plan
go test ./internal/workspace/... ./cmd/... -count=1 -run 'Runbook|Embed|Filtered|InitCheck'go test ./internal/workspace/... ./cmd/... -count=1TestRunbookInitCheckPasses—kiwifs checkexit 0 on generated scaffoldTestRunbookEmbedUsesUC6ScaffoldOnly— legacy paths excluded from embedTestExampleRunbookHasSevenSections— all 7 UC-6 sections + fenced bash blocksTestRunbookSchemaValidatesExample/TestRunbookSchemaRejectsInvalidFrontmatter— JSON Schema fortrigger,severity,owner,servicesMade with Cursor