fix(workspace): harden runbook init with embed filter and service stubs (#325)#73
Open
advancedresearcharray wants to merge 5 commits into
Open
fix(workspace): harden runbook init with embed filter and service stubs (#325)#73advancedresearcharray wants to merge 5 commits into
advancedresearcharray wants to merge 5 commits into
Conversation
…bs (kiwifs#325) Filter legacy runbook scaffold paths from the embedded template FS so placeholder wiki links never ship via init. Add api-service and monitoring service stubs so example runbook frontmatter links resolve cleanly. Co-authored-by: Cursor <cursoragent@cursor.com>
…on (kiwifs#325) Co-authored-by: Cursor <cursoragent@cursor.com>
advancedresearcharray
force-pushed
the
feat/issue-325-runbook-init-delivery
branch
from
6e26526 to
1a0ed40
Compare
advancedresearcharray
changed the title
kiwifs#325) Co-authored-by: Cursor <cursoragent@cursor.com>
Peer review follow-up: mirror memory template absent-list pattern so init embed regression is guarded at the CLI layer. Co-authored-by: Cursor <cursoragent@cursor.com>
…eview pass (kiwifs#325) Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filteredTemplatesFSto exclude legacy runbook dirs (incidents/,postmortems/,procedures/) and other dev-only paths fromkiwifs initembeds — fixes broken-link lint failures on generated workspacesservices/api-service.mdandservices/monitoring.mdstubs so[[api-service]]/[[monitoring]]wiki links inexample-high-cpu.mdresolve cleanlyTestRunbookEmbedUsesUC6ScaffoldOnly, service stub paths in init/scaffold assertionsCloses kiwifs#325
Acceptance criteria
kiwifs init --template runbookcreates the UC-6 scaffold (SCHEMA, index, example, schema, blank template, service stubs)example-high-cpu.mdhas all 7 sections with fenced bash blocks and expected outputrunbook.jsonvalidates required fields:type,title,trigger,severity,owner,serviceskiwifs checkpasses on generated scaffold (info-level orphans only on README/SCHEMA/playbook)Test plan
go test ./internal/workspace/... ./cmd/... -count=1go test ./internal/workspace/... -run 'Runbook|runbook|Embed|Filtered' -count=1go test ./... -count=1kiwifs init --root /tmp/runbook-test-ws-325 --template runbookthenkiwifs check --root /tmp/runbook-test-ws-325(exit 0)